Skip to content

Tune extrinsic base fee#1576

Merged
notlesh merged 13 commits intomasterfrom
notlesh-custom-base-weight
Aug 11, 2022
Merged

Tune extrinsic base fee#1576
notlesh merged 13 commits intomasterfrom
notlesh-custom-base-weight

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Jun 7, 2022 •
edited
Loading

What does it do?

Implements a custom BlockWeights for the moonbase runtime in order to tune the extrinsic base fee charged in pallet-transaction-payment.

This is essentially the last relevant changes extracted out of #1218.

⚠️ Breaking Changes ⚠️

⚠️ All substrate-based fees will be impacted by this
⚠️ Some txns in the mempool prior to this change (runtime upgrade) may become invalid
⚠️ RPC calls to estimate fees will return different values
🧷 This only affects moonbase runtimes currently

@notlesh notlesh added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D2-breaksapi This PR changes public API; next release should be major. D3-breaksconsensus The PR alters the node runtime and/or the SRML modules such that the logic is materially different. D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D10-breaksdocs Changes to code that require changes in documentation labels Jun 7, 2022
@notlesh notlesh mentioned this pull request Jun 7, 2022
Closed
tgmichel
tgmichel approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@tgmichel tgmichel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a ~3x base increase for frame extrinsics to align with Ethereum gas cost.

crystalin
crystalin approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the code, but approve the idea

@notlesh notlesh merged commit 28f7438 into master Aug 11, 2022
@notlesh notlesh deleted the notlesh-custom-base-weight branch August 11, 2022 15:06
@notlesh notlesh mentioned this pull request Aug 11, 2022
Merged
@notlesh notlesh mentioned this pull request Nov 10, 2022
Merged
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crystalin crystalin crystalin approved these changes

+1 more reviewer

@tgmichel tgmichel tgmichel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D2-breaksapi This PR changes public API; next release should be major. D3-breaksconsensus The PR alters the node runtime and/or the SRML modules such that the logic is materially different. D10-breaksdocs Changes to code that require changes in documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notlesh @crystalin @tgmichel