Skip to content

Configurable runtimes in ts tests for length fee changes#1585

Merged
notlesh merged 10 commits intonotlesh-length-fee-changes-moonriver-moonbeamfrom
notlesh-length-fees-tests-runtime-support
Jun 13, 2022
Merged

Configurable runtimes in ts tests for length fee changes#1585
notlesh merged 10 commits intonotlesh-length-fee-changes-moonriver-moonbeamfrom
notlesh-length-fees-tests-runtime-support

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Jun 9, 2022

What does it do?

This PR proposes a way to configure which runtime a ts test should be run against and uses this new feature to test length fees which currently differ for each runtime.

@notlesh notlesh requested a review from crystalin June 9, 2022 22:26
@notlesh notlesh added B0-silent Changes should not be mentioned in any release notes I4-tests 🎯 Tests need fixing, improving or augmenting. D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jun 9, 2022
@notlesh notlesh merged commit 60b54ed into notlesh-length-fee-changes-moonriver-moonbeam Jun 13, 2022
@notlesh notlesh deleted the notlesh-length-fees-tests-runtime-support branch June 13, 2022 23:24
notlesh added a commit that referenced this pull request Jun 14, 2022
* Bring LengthToFee changes to Moonriver and Moonbeam runtimes

* Use WeightToFee from Runtime in xcm_config

* Clean up

* Update TRANSACTION_BYTE_FEE

* Add length_fee test to moonriver and moonbeam runtimes

* Remove irrelevant test

* Configurable runtimes in ts tests for length fee changes (#1585)

* Support running different runtimes in ts tests

* Add length fee tests with different expect()s per runtime

* Test runtime upgrade length fees

* Some DRY

* Typos

* prettier

* Update tests/tests/test-fees/test-length-fees.ts

Co-authored-by: Alan Sapede <alan@purestake.com>

* Avoid use any, prefer const over let

* prettier

* Avoid peer connections on moonbeam nodes in ts tests

Co-authored-by: Alan Sapede <alan@purestake.com>

Co-authored-by: Alan Sapede <alan@purestake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit I4-tests 🎯 Tests need fixing, improving or augmenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants