Skip to content

Bring LengthToFee changes to Moonriver and Moonbeam runtimes#1579

Merged
notlesh merged 8 commits intomasterfrom
notlesh-length-fee-changes-moonriver-moonbeam
Jun 14, 2022
Merged

Bring LengthToFee changes to Moonriver and Moonbeam runtimes#1579
notlesh merged 8 commits intomasterfrom
notlesh-length-fee-changes-moonriver-moonbeam

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Jun 8, 2022 •
edited
Loading

What does it do?

Brings the LengthToFee changes introduced for moonbase in runtime 1600 (#1496) to moonbeam and moonriver runtimes.

This effectively reduces length fees and increases weight fees for substrate-based txns. Ethereum txns are unaffected.

⚠️ Breaking Changes ⚠️

⚠️ All substrate-based fees will be impacted by this
⚠️ Some txns in the mempool prior to this change (runtime upgrade) may become invalid
⚠️ RPC calls to estimate fees will return different values

📋 TODO

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D2-breaksapi This PR changes public API; next release should be major. D3-breaksconsensus The PR alters the node runtime and/or the SRML modules such that the logic is materially different. D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D10-breaksdocs Changes to code that require changes in documentation labels Jun 8, 2022
notlesh
notlesh commented Jun 8, 2022
View reviewed changes
@notlesh notlesh requested a review from crystalin June 9, 2022 23:45
@notlesh
Configurable runtimes in ts tests for length fee changes (#1585)
60b54ed 
* Support running different runtimes in ts tests

* Add length fee tests with different expect()s per runtime

* Test runtime upgrade length fees

* Some DRY

* Typos

* prettier

* Update tests/tests/test-fees/test-length-fees.ts

Co-authored-by: Alan Sapede <alan@purestake.com>

* Avoid use any, prefer const over let

* prettier

* Avoid peer connections on moonbeam nodes in ts tests

Co-authored-by: Alan Sapede <alan@purestake.com>
crystalin
crystalin approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd suggest to avoid an additional review too

@notlesh notlesh merged commit d4a37e0 into master Jun 14, 2022
@notlesh notlesh deleted the notlesh-length-fee-changes-moonriver-moonbeam branch June 14, 2022 14:35
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crystalin crystalin crystalin approved these changes

Assignees

No one assigned

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D2-breaksapi This PR changes public API; next release should be major. D3-breaksconsensus The PR alters the node runtime and/or the SRML modules such that the logic is materially different. D10-breaksdocs Changes to code that require changes in documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notlesh @crystalin