Conversation
tgmichel
added
A0-pleasereview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
A followup of #1006,
eth_feeHistoryrpc method.What important points reviewers should know?
BaseFeepallet is added to moonbeam and moonriver runtimes. This is required by a new Ethereum Runtime Api version, which makes use of it. In both Moonbeam and Moonriver runtimes the pallet is set to inactive, meaning for both runtimes we still use the fixed gas price model.Once we decide to enable it, we will need to change the IsActive associated type value in both runtimes which is used in the pallet's
on_runtime_upgradeand useBaseFeeas the pallet-evm'sFeeCalculator.