Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stub for GifQuantizeBuffer() which was removed in giflib 5.1.9 #572

Closed
wants to merge 1 commit into from
Closed

Add stub for GifQuantizeBuffer() which was removed in giflib 5.1.9 #572

wants to merge 1 commit into from

Conversation

akoeplinger
Copy link
Member

This is similar to #37 except this time they removed the function completely.
Adding a stub which just ignores quantization until we have a use case that would require bringing back the functionality.

Fixes #546

@akoeplinger
Add stub for GifQuantizeBuffer() which was removed in giflib 5.1.9
4ca08d8 
This is similar to mono#37 except this time they removed the function completely.
Adding a stub which just ignores quantization until we have a use case that would require bringing back the functionality.

Fixes mono#546
@akoeplinger
Copy link
Member Author

Hm this does cause a few test failures in System.Drawing if we just use the stub:

1) Save_24bppRgb (MonoTests.System.Drawing.Imaging.GifCodecTest.Save_24bppRgb)
     R
  Expected: True
  But was:  False

  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save (System.Drawing.Imaging.PixelFormat original, System.Drawing.Imaging.PixelFormat expected, System.Boolean exactColorCheck) [0x00102] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:244
  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save_24bppRgb () [0x00000] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:264
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395


2) Save_32bppArgb (MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppArgb)
     R
  Expected: True
  But was:  False

  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save (System.Drawing.Imaging.PixelFormat original, System.Drawing.Imaging.PixelFormat expected, System.Boolean exactColorCheck) [0x00102] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:244
  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppArgb () [0x00000] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:276
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395


3) Save_32bppPArgb (MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppPArgb)
     R
  Expected: True
  But was:  False

  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save (System.Drawing.Imaging.PixelFormat original, System.Drawing.Imaging.PixelFormat expected, System.Boolean exactColorCheck) [0x00102] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:244
  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppPArgb () [0x00000] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:282
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395


4) Save_32bppRgb (MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppRgb)
     R
  Expected: True
  But was:  False

  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save (System.Drawing.Imaging.PixelFormat original, System.Drawing.Imaging.PixelFormat expected, System.Boolean exactColorCheck) [0x00102] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:244
  at MonoTests.System.Drawing.Imaging.GifCodecTest.Save_32bppRgb () [0x00000] in /mono/mcs/class/System.Drawing/Test/System.Drawing.Imaging/GifCodecTest.cs:270
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395

@akoeplinger
Copy link
Member Author

Going with #575 instead.

@akoeplinger akoeplinger closed this Aug 1, 2019
@akoeplinger akoeplinger deleted the gifquantizebuffer branch August 1, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libgdiplus does not compile with giflib >= 5.1.9
1 participant
@akoeplinger