Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch from Romain Tartiere #37

Closed
wants to merge 1 commit into from
Closed

Conversation

9999-ebuilds
Copy link

see https://bugs.funtoo.org/browse/FL-816
and gentoo/dotnet#173

../src/.libs/libgdiplus.so: undefined reference to `QuantizeBuffer'
QuantizeBuffer has been removed since giflib 4.2.0
FreeBSD developer Romain Tartiere wrote a patch, which adds QuantizeBuffer to libgdiplus code.

2012-06-03, Romain Tartiere:

"Fix build after giflib update.

QuantizeBuffer() is no more public in the giflib but still present in the code.
There is no update (yet) code in the libgdiplus code so copy the relevant lines
from giflib for now."

@monojenkins
Copy link

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@akoeplinger
Copy link
Member

We can't take the code from giflib directly due to licensing reasons. Given that this API made a comeback in giflib 5 and most distros/OSes either stuck with 4.1 or moved to 5.0 it shouldn't be too common in the future.

For the remaining cases with giflib 4.2 I've added a stub instead which simply does nothing and prints a warning: aeccb51

Thanks!

akoeplinger added a commit to akoeplinger/libgdiplus that referenced this pull request Jul 31, 2019
This is similar to mono#37 except this time they removed the function completely.
Adding a stub which just ignores quantization until we have a use case that would require bringing back the functionality.

Fixes mono#546
akoeplinger added a commit to akoeplinger/libgdiplus that referenced this pull request Jul 31, 2019
This is similar to mono#37 except this time they removed the function completely.
Adding a stub which just ignores quantization until we have a use case that would require bringing back the functionality.

Fixes mono#546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants