Remove skiasharp-docker service connection from native bootstrapper#4310
Conversation
Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4310PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4310"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4310/packages --name skiasharp-pr-4310More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4310 |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Removes the now-unused skiasharp-docker private-registry authentication steps from the native build bootstrapper Azure Pipelines template, leaving Docker image build/run behavior unchanged.
Changes:
- Drops the 1ES
templateContext.authenticatedContainerRegistriesentry that referencedserviceConnection: skiasharp-docker. - Removes the non-1ES
Docker@2registry login step that usedcontainerRegistry: skiasharp-docker.
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
|
@copilot please give me a pr merge commit message using the skill |
|
Brings in the 7 commits that landed on main after this sync branch was originally cut (yesterday's automated main-tip run): - e00fa55 [skia-sync] Merge upstream chrome/m151 bug fixes (#4312) - a1ecb75 docs: regenerate API diffs and polish release notes (#4322) - 1c49b4a Remove unnecessary 'unsafe' modifier from GRContextOptions (#3991) - 2d15749 Update docs submodule to latest main (#4304) - 7356c75 [docs-site] Skip PR staging previews for non-site file changes (#4321) - a95cc35 [docs-site] Add 'Moving faster with AI' dashboard to the AI page (#4318) - 72ce599 [infra] Remove obsolete skiasharp-docker registry auth (#4310) Conflicts resolved: - cgmanifest.json: took origin/main (will be overwritten by update-versions.ps1 in the next commit with the new sync SHAs). - externals/skia: took ours (90a2d04943 is a descendant of 98877992a5 from PR #4312 via the corresponding submodule merge PR #278). - docs submodule pointer: took origin/main (b64a0266c from PR #4304). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e provisioning) (#4522) [infra] Backport CI fixes to release/4.150.x (#4522) Context: https://dev.azure.com/dnceng-public/public/_build?definitionId=345 Cherry-picks: #4310, #4320 The new public `mono-SkiaSharp` Azure DevOps pipeline (dnceng-public, definition 345) failed on `release/4.150.x` at YAML compile time — the build died in 0s with no timeline before any job ran: The pipeline is not valid. Job native_linux_arm64_linux: Step Docker1 input containerRegistry references service connection skiasharp-docker which could not be found. ... Job native_linux_x86_linux: Step Docker1 ... skiasharp-docker `main` had already dropped that stale dependency, but `release/4.150.x` was cut before those fixes, so every run on the branch was a hard compile failure. This backports the two infra commits needed to make the branch build under the new pipeline. No product code is touched — only pipeline templates (30 deletions). Remove obsolete skiasharp-docker registry auth (#4310) The native bootstrapper only builds a local image from the checked-in Dockerfile and runs it; the private-registry login was obsolete. Removing the 1ES `authenticatedContainerRegistries` entry and the classic `Docker@2 login` task drops the reference to the `skiasharp-docker` service connection, which does not exist in the dnceng-public project. This is the change that lets the pipeline compile. Remove Apple certificate and provisioning profile steps from tests (#4320) With the compile blocker gone, the iOS/macOS/tvOS test jobs would then fail at runtime: `InstallAppleCertificate`/`InstallAppleProvisioningProfile` load secure files (`SkiaSharp iOS Certificate.p12`, etc.) that are not present in the new public project. Dropping those steps (and the now-unused provisioning-profiles template) keeps the test stage runnable. Verified: after both cherry-picks, PR #4522 triggered build 20260722.23, which gets past YAML validation and expands all 12 stages (instead of failing instantly at compile). m151 milestone changes (#4294) were deliberately excluded — 4.150.x stays on m150. Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description of Change
Drops the now-unused
skiasharp-dockerDocker service connection from the native build bootstrapper template.authenticatedContainerRegistriesblock (serviceConnection: skiasharp-docker) fromtemplateContexton the 1ES path.Docker@2login task (containerRegistry: skiasharp-docker) on the non-1ES path.Docker image build/run steps are unchanged; only the private-registry authentication is dropped.
Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist