Remove unnecessary unsafe modifier from GRContextOptions#3991
Merged
Conversation
10 tasks
Agent-Logs-Url: https://github.com/mono/SkiaSharp/sessions/a25f7a0d-002f-44d0-9122-e3a99cbfa345 Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unnecessary class-level unsafe modifier from GRContextOptions
Remove unnecessary May 15, 2026
unsafe modifier from GRContextOptions
mattleibow
marked this pull request as ready for review
July 2, 2026 19:40
mattleibow
pushed a commit
that referenced
this pull request
Jul 3, 2026
Brings in the 7 commits that landed on main after this sync branch was originally cut (yesterday's automated main-tip run): - e00fa55 [skia-sync] Merge upstream chrome/m151 bug fixes (#4312) - a1ecb75 docs: regenerate API diffs and polish release notes (#4322) - 1c49b4a Remove unnecessary 'unsafe' modifier from GRContextOptions (#3991) - 2d15749 Update docs submodule to latest main (#4304) - 7356c75 [docs-site] Skip PR staging previews for non-site file changes (#4321) - a95cc35 [docs-site] Add 'Moving faster with AI' dashboard to the AI page (#4318) - 72ce599 [infra] Remove obsolete skiasharp-docker registry auth (#4310) Conflicts resolved: - cgmanifest.json: took origin/main (will be overwritten by update-versions.ps1 in the next commit with the new sync SHAs). - externals/skia: took ours (90a2d04943 is a descendant of 98877992a5 from PR #4312 via the corresponding submodule merge PR #278). - docs submodule pointer: took origin/main (b64a0266c from PR #4304). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
GRContextOptionswas declaredpublic unsafe classdespite containing zero unsafe code — no pointers, nofixedblocks, nostackalloc. Remove the unnecessary modifier.Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist
No tests needed — keyword-only removal with no behavioral or ABI impact.