Uno.WinUI by anpin · Pull Request #1960 · mono/SkiaSharp

anpin · 2022-02-20T09:43:13Z

Description of Change

Added views for Uno.WinUI #1787

Bugs Fixed

Fixed breaking changes in MAUI handlers (they renamed Native views to Platform views)

API Changes
None

Behavioral Changes

None

PR Checklist

Has tests (For some reason none of the Uno views has tests, so I haven't done one either)
Rebased on top of main at time of PR
Changes adhere to coding standard
Updated documentation

anpin · 2022-02-20T09:47:04Z

At the moment I'm experiencing a strange issue with SkiaSharp.Views.Uno.WinUI.Mobile project. Compiling it to targets other than net6.0-android fails due to ignored conditional compilation symbols

mattleibow · 2022-02-21T00:04:06Z

To speed up the CI bulds and skip the unmanaged builds, change the number from 0 to 5768468 https://github.com/mono/SkiaSharp/blob/main/scripts/azure-pipelines.yml#L15

That number is just a last green build here. It expires after a while and it may not work if you change unmanaged files, but it is the best I have now. I need to write some yaml to allow you to somehow (maybe with a github tag) to skip the unmnaged builds. But for now, numbers!!!

mattleibow · 2022-02-21T00:15:30Z

The rename from native to platform is in maui preview 14. Is that the version you are wanting to target? only preview 13 is out right now. We can totally release a new p13 build of skia with uno.ui and then update to p14 once that is closer to release

mattleibow · 2022-02-21T00:15:58Z

CI iscurrently failing because of a missing package in our dotnet-puyblic feed. Asked them to add that now.

anpin · 2022-02-21T08:06:32Z

The rename from native to platform is in maui preview 14. Is that the version you are wanting to target? only preview 13 is out right now. We can totally release a new p13 build of skia with uno.ui and then update to p14 once that is closer to release

I wanted to target Uno WinUI 3, so we can exclude the MAUI changes. I renamed them just so I won't get an error in latest VS2022 preview.

mattleibow · 2022-02-21T18:38:01Z

Seems the skip does not work for forks 😢

I thinkn this is the next thing I need to get working on CI. But for the time being, back to square 0 it seems.

revert buildExternals number back to 0

anpin · 2022-03-01T10:31:41Z

@mattleibow is there anything else I can do to help merge this?

jeromelaban

This PR adds net6 targets for samples and gallery, which cannot work unless the referenced SkiaSharp.Views.Uno.WinUI libraries also reference net6.0-android, ios, etc..

There's also a need for Uno to be updated to the latest preview 14 bits (because of iOS/mac breaking changes), which will be happening in the next few days.

jeromelaban · 2022-03-17T19:39:40Z

 using Windows.UI;

-#if WINDOWS
+#if WINDOWS || WINUI


It's likely that changing all references to WINUI would make more sense, which means adding WINUI as a constant in the existing WinUI project.

jeromelaban · 2022-03-22T15:56:28Z

The Uno Platform release 4.1.9 now supports net6.0-ios, net6.0-android, net6.0-maccatalyst and net6.0-macos. It can be used to add the new targets compatible with the mobile template used in this PR.

anpin · 2022-04-05T10:40:09Z

It seems to me that Uno.WinUI packages are still missing on the CI nuget feed, so it only compiles when I add public feed to nuget.config. Plus there is still something wrong with net6.0-ios and net6.0-maccatalyast targets and you ca n follow discussion in the msbuild issue linked above.

jeromelaban · 2022-04-05T12:37:25Z

Yes, the Uno.WinUI.* packages need to be approved by the SkiaSharp team for the build to go further.

jeromelaban · 2022-04-06T00:45:33Z

Here are the uno packages for this PR:

uno.core
uno.core.extensions
uno.core.extensions.collections
uno.core.extensions.compatibility
uno.core.extensions.disposables
uno.core.extensions.equality
uno.core.extensions.logging
uno.core.extensions.logging.singleton
uno.core.extensions.threading
uno.diagnostics.eventing
uno.extensions.core
uno.extensions.logging.oslog
uno.extensions.logging.webassembly.console
uno.extensions.logging.winui
uno.foundation.logging
uno.foundation.runtime.webassembly
uno.sourcegenerationtasks
uno.ui.adapter.microsoft.extensions.logging
uno.universalimageloader
uno.wasm.bootstrap
uno.wasm.bootstrap.devserver
uno.wasm.websockets
uno.winui
uno.winui.remotecontrol
uno.winui.runtime.skia.gtk
uno.winui.runtime.skia.wpf
uno.winui.runtime.webassembly
uno.winui.skia.gtk
uno.winui.skia.wpf
uno.winui.webassembly
commonservicelocator

mattleibow · 2022-04-06T14:16:26Z

Should be available now. I asked for the latest, so maybe we need some older versions too. When you remove the nuget.config we will know.

anpin · 2022-04-06T14:44:30Z

I haven’t committed nuget.config, so it should be good to goOn Wed, Apr 6, 2022 at 6:16 PM, Matthew Leibowitz ***@***.***> wrote: Should be available now. I asked for the latest, so maybe we need some older versions too. When you remove the nuget.config we will know. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

mattleibow · 2022-04-06T14:46:29Z

There are the nuget.configs in the samples folders. We can't have any nuget.configs anywhere in the repo that have nuget.org or any other non-azure feeds.

anpin · 2022-04-06T14:49:05Z

Ok my bad maybe I did add them. I’m on mobile, so will fix it later. On Wed, Apr 6, 2022 at 6:46 PM, Matthew Leibowitz ***@***.***> wrote: There are the nuget.configs in the samples folders. We can't have any nuget.configs anywhere in the repo that have nuget.org or any other non-azure feeds. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

mattleibow · 2022-04-09T01:07:41Z

There is 1 more: samples/Basic/Uno/NuGet.config

Starting: Nuget Security Analysis (auto-injected by policy)
==============================================================================
Task         : Nuget Security Analysis
Description  : A task to scan for vulnerabilities in nuget files.
Version      : 0.2.102
Author       : Microsoft Corporation
Help         : See https://aka.ms/nugetsecurityanalysis for more information. Please contact OpenSourceEngSupport@microsoft.com if you run into problems or have questions with this task.
==============================================================================
For more information please visit: https://aka.ms/nugetsecurityanalysis
Starting Multifeed Nuget Security Analysis: 
nuget.config - Multiple internal feeds declared, but none with upstreams.
samples/Basic/Uno/NuGet.config - Missing <clear/> statement.
samples/Basic/Uno/NuGet.config - Multiple feeds declared.
Starting Multifeed Python Security Analysis: 
Starting CFS NuGet Analysis: 
samples/Basic/Uno/NuGet.config - External feeds found in the file.
Starting CFS NPM Analysis: 
Starting DockerFile Analysis: 
scripts/Docker/alpine/amd64/Dockerfile - Container usage from external registry 'docker.io' found.
scripts/Docker/debian9/amd64/Dockerfile - Container usage from external registry 'docker.io' found.
scripts/Docker/debian9/clang-cross/Dockerfile - Container usage from external registry 'docker.io' found.
Azure Artifacts Configuration Analysis found 1 vulnerable NuGet package manifest in the repository. Visit http://aka.ms/azure-artifacts-configuration-analysis for more details.
Container security analysis found 3 violations. This repo has one or more docker files having references to images from external registries. Please review https://aka.ms/containers-security-guidance to remove the reference of container images from external registries. Please contact cssc@microsoft.com for any questions or clarifications.
##[error]NuGet Security Analysis found 1 vulnerable package manifest in the repository. Visit https://aka.ms/nugetmultifeed for more details.
Finishing: Nuget Security Analysis (auto-injected by policy)

mattleibow · 2022-04-12T14:35:58Z

I notice this in the logs:

CSC : warning CS8002: Referenced assembly 'Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.Foundation, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.UI.BindingHelper.Android, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.UI.FluentTheme, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.UI.FluentTheme.v1, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.UI.FluentTheme.v2, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         CSC : warning CS8002: Referenced assembly 'Uno.UI.Toolkit, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]

Did the net6 uno loose the strong name?

jeromelaban · 2022-04-12T14:46:53Z

Uno never had strong names (and likely never will). Could it be that the skia build requires strong names in net6?

mattleibow

Just some comments, all looking really close.

mattleibow · 2022-05-10T16:17:43Z

    <AssemblyName>SkiaSharp.Views.Windows</AssemblyName>
    <PackagingGroup>SkiaSharp.Views.WinUI</PackagingGroup>
+    <DefineConstants>$(DefineConstants);WINDOWS</DefineConstants>
+    <PublishTrimmed>false</PublishTrimmed>


Do we need this?

Also, isn't WINDOWS already defined? Did you mean WINUI instead? How does this (if at all) relate to the || WINUI added in the cs?

The PublishTrimmed is scattered thought... is that needed as I think it is an app feature.

mattleibow · 2022-05-10T16:22:53Z

+    <RootNamespace>SkiaSharp.Views.UWP</RootNamespace>
+    <AssemblyName>SkiaSharp.Views.UWP</AssemblyName>
+    <PackagingGroup>SkiaSharp.Views.Uno.WinUI</PackagingGroup>
+    <PackageId>SkiaSharp.Views.Uno.WinUI</PackageId>


This may need a <SignAssembly>false to disable strong naming for Uno things. I see it is in the skia/wasm projects...

mattleibow · 2022-05-10T16:26:06Z

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="SkiaSharp" android:versionCode="1" android:versionName="1.0">


This file should not be in a library.

Nor the info.plists.

msbuild was failing without these two files unfortunately, not sure if it is still doing this

@anpin I can take over this PR and finish it, if that's fine with you. I'll have to re-create it and I'll keep the history.

@jeromelaban I don't mind that as my attention shifted on something else and I no longer need this actually

@anpin Thanks! I'll open another PR then.

mattleibow · 2022-05-10T16:28:44Z

      "SkiaSharp.Views.Uno\\SkiaSharp.Views.Uno.Reference\\SkiaSharp.Views.Uno.Reference.csproj",
      "SkiaSharp.Views.Uno\\SkiaSharp.Views.Uno.Skia\\SkiaSharp.Views.Uno.Skia.csproj",
      "SkiaSharp.Views.Uno\\SkiaSharp.Views.Uno.Wasm\\SkiaSharp.Views.Uno.Wasm.csproj",
+      "SkiaSharp.Views.Uno\\SkiaSharp.Views.Uno.WinUI.Mobile\\SkiaSharp.Views.Uno.WinUI.Mobile.csproj",


Need to confirm if SkiaSharp.Views.Uno.WinUI.Mobile.csproj builds with netfx... I was having issues - but I think that was months ago so maybe it all works now :)

mattleibow · 2022-05-14T04:32:34Z

The Windows builds are failing with:

       "D:\a\1\s\source\SkiaSharpSource.Windows-net6.slnf" (Build target) (1:2) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (default target) (10:22) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (Build target) (10:25) ->
       (CoreCompile target) -> 
         D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.iOS\SKSwapChainPanel.iOS.cs(14,11): error CS0246: The type or namespace name 'SKGLView' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]


       "D:\a\1\s\source\SkiaSharpSource.Windows-net6.slnf" (Build target) (1:2) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (default target) (10:22) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (Build target) (10:26) ->
         D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.Mac\SKXamlCanvas.macOS.cs(3,23): error CS0234: The type or namespace name 'Mac' does not exist in the namespace 'SkiaSharp.Views' (are you missing an assembly reference?) [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         D:\a\1\s\source\SkiaSharp.Views\SkiaSharp.Views.Mac\SKGLView.cs(6,23): error CS0234: The type or namespace name 'GlesInterop' does not exist in the namespace 'SkiaSharp.Views' (are you missing an assembly reference?) [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]
         D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.Mac\SKXamlCanvas.macOS.cs(14,11): error CS0246: The type or namespace name 'SKCGSurfaceFactory' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]


       "D:\a\1\s\source\SkiaSharpSource.Windows-net6.slnf" (Build target) (1:2) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (default target) (10:22) ->
       "D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj" (Build target) (10:23) ->
         D:\a\1\s\source\SkiaSharp.Views\SkiaSharp.Views.AppleiOS\SKGLView.cs(9,23): error CS0234: The type or namespace name 'GlesInterop' does not exist in the namespace 'SkiaSharp.Views' (are you missing an assembly reference?) [D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.WinUI.Mobile\SkiaSharp.Views.Uno.WinUI.Mobile.csproj]

mattleibow · 2022-05-27T21:37:43Z

Merged in 7b3e8f3 via #2042

anpin added 2 commits February 19, 2022 19:11

Fixed breaking API changes in MAUI handlers

b6dbca6

Added Uno.WinUI views and samples

469e25f

mattleibow added the area/SkiaSharp.Views.Uno label Feb 21, 2022

Skipping unmanged builds in CI

4641be0

anpin added 3 commits February 23, 2022 11:15

Merge branch 'main' into main

e5b2e42

Update azure-pipelines.yml

12b4515

revert buildExternals number back to 0

Merge branch 'main' into main

3287ffc

anpin mentioned this pull request Mar 10, 2022

Conditional compilation ignored dotnet/msbuild#7457

Closed

jeromelaban reviewed Mar 17, 2022

View reviewed changes

inforithmics mentioned this pull request Mar 27, 2022

updated uno.ui to stable 4.1.9 instead of preview Mapsui/Mapsui#1576

Merged

anpin added 4 commits April 5, 2022 13:59

Merge branch 'mono:main' into main

9443bbd

Merge branch 'main' of https://github.com/mono/SkiaSharp

b1d0f19

Merge branch 'main' of https://github.com/anpin/SkiaSharp

8a43b3f

bumped Uno.WinUI to 4.1.9

dc88499

Removed unnecessary nuget configs

1913bed

Delete NuGet.config

068f47f

mattleibow reviewed May 10, 2022

View reviewed changes

Merge branch 'main' into main

87d34b1

Merge branch 'mono:main' into main

d7500e0

jeromelaban mentioned this pull request May 16, 2022

Add WinUI support #2042

Merged

4 tasks

mattleibow added this to the v2.88.1 milestone May 22, 2022

mattleibow closed this May 27, 2022

		@@ -0,0 +1,5 @@
		<?xml version="1.0" encoding="utf-8"?>
		<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="SkiaSharp" android:versionCode="1" android:versionName="1.0">

Uh oh!

Conversation

anpin commented Feb 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anpin commented Feb 20, 2022

Uh oh!

mattleibow commented Feb 21, 2022

Uh oh!

mattleibow commented Feb 21, 2022

Uh oh!

mattleibow commented Feb 21, 2022

Uh oh!

anpin commented Feb 21, 2022

Uh oh!

mattleibow commented Feb 21, 2022

Uh oh!

anpin commented Mar 1, 2022

Uh oh!

jeromelaban left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromelaban Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromelaban commented Mar 22, 2022

Uh oh!

anpin commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeromelaban commented Apr 5, 2022

Uh oh!

jeromelaban commented Apr 6, 2022

Uh oh!

mattleibow commented Apr 6, 2022

Uh oh!

anpin commented Apr 6, 2022 via email

Uh oh!

mattleibow commented Apr 6, 2022

Uh oh!

anpin commented Apr 6, 2022 via email

Uh oh!

mattleibow commented Apr 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattleibow commented Apr 12, 2022

Uh oh!

jeromelaban commented Apr 12, 2022

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromelaban May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattleibow commented May 14, 2022

Uh oh!

anpin commented Feb 20, 2022 •

edited

Loading

jeromelaban left a comment •

edited

Loading

jeromelaban Mar 17, 2022 •

edited

Loading

anpin commented Apr 5, 2022 •

edited

Loading

mattleibow commented Apr 9, 2022 •

edited

Loading

jeromelaban May 13, 2022 •

edited

Loading

mattleibow commented May 27, 2022 •

edited

Loading