Skip to content

fix: use require instead of readFileSync for driver.version (#2937) #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emadum merged 3 commits into from
Dec 4, 2020
Merged

fix: use require instead of readFileSync for driver.version (#2937) #2652

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb5b4eb
fix: use require instead of readFileSync for driver.version (#2937)
aherlihy Dec 2, 2020
7bec2c7
lint
aherlihy Dec 2, 2020
ea47a72
remove require
aherlihy Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,9 +885,8 @@ export interface ClientMetadataOptions {
appname?: string;
}

const NODE_DRIVER_VERSION = JSON.parse(
readFileSync(resolve(__dirname, '..', 'package.json'), { encoding: 'utf-8' })
).version;
// eslint-disable-next-line @typescript-eslint/no-var-requires
const NODE_DRIVER_VERSION = require('../package.json').version;

export function makeClientMetadata(options: ClientMetadataOptions): ClientMetadata {
options = options || {};
Expand Down