fix: use require instead of readFileSync for driver.version (#2937) #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(@aherlihy I just added people for review myself so should be all good) |
emadum
suggested changes
Dec 2, 2020
Contributor
emadum
left a comment
emadum
left a comment
There was a problem hiding this comment.
there are a few lint errors from the now-unused vars:
warning 'readFileSync' is defined but never used @typescript-eslint/no-unused-vars
warning 'resolve' is defined but never used @typescript-eslint/no-unused-vars
Contributor
Author
|
Right! Sorry I missed that, should be done @emadum |
emadum
approved these changes
Dec 4, 2020
nbbeeken
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the solution mongosh is currently using in my fork of the driver. I don't know if you want to use this directly or some other solution. For more details see NODE-2937