SERVER-30166 Replace string with explicit std::string. Enables compul…#1167
Closed
greenius wants to merge 1 commit intomongodb:masterfrom
Closed
SERVER-30166 Replace string with explicit std::string. Enables compul…#1167greenius wants to merge 1 commit intomongodb:masterfrom
greenius wants to merge 1 commit intomongodb:masterfrom
Conversation
…ation when using --use-system-pcre which presusably used to do 'using std::string' in an earlier version of pcre
Contributor
|
@greenius Thanks for the contribution |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces string with std::string in several files so it will build when using --using-system-pcre with libpcre 8.41.
This is the equivalent of Pull Request #1166 but applies to master instead of 3.4 branch.