Skip to content

mongodb: 3.2.9 -> 3.4.1#22050

Merged
LnL7 merged 2 commits intoNixOS:masterfrom
Avaq:update-mongodb
Nov 1, 2017
Merged

mongodb: 3.2.9 -> 3.4.1#22050
LnL7 merged 2 commits intoNixOS:masterfrom
Avaq:update-mongodb

Conversation

@Avaq
Copy link
Member

@Avaq Avaq commented Jan 23, 2017

Motivation for this change

The desire to use MondoDB's $replaceRoot aggregation operator.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Avaq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @rvl to be potential reviewers.

Copy link
Member Author

@Avaq Avaq Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain changed to fastdl because that's what I found on the MongoDB website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch removed because it is included in the source.

@LnL7 LnL7 added the 8.has: package (update) This PR updates a package to a newer version label Jan 23, 2017
@LnL7
Copy link
Member

LnL7 commented Jan 23, 2017

@zimbatm
Copy link
Member

zimbatm commented Feb 19, 2017

I'm still getting the segfault on darwin after the update. I suggest forking the package in two where mongodb_3_2 is the default and mongodb_3_4 the new one that only works on linux.

@zimbatm
Copy link
Member

zimbatm commented Feb 19, 2017

Maybe https://github.com/Homebrew/homebrew-core/blob/master/Formula/mongodb.rb will give us some hints like the requirement on cxx11

@fpletz fpletz added this to the 17.03 milestone Feb 26, 2017
@globin globin removed this from the 17.03 milestone Mar 13, 2017
@disassembler
Copy link
Member

@zimbatm @LnL7 @copumpkin can we test this on darwin again and see if it still segfaults?

@LnL7
Copy link
Member

LnL7 commented Nov 1, 2017

This might have been fixed by #27598, I don't remember if I tested this afterwards.

@Avaq Avaq requested a review from nbp as a code owner November 1, 2017 13:21
@LnL7 LnL7 merged commit c8dd4e7 into NixOS:master Nov 1, 2017
@vcunat
Copy link
Member

vcunat commented Nov 2, 2017

Merged just now when mongodb needs another patch due to a std::string change in pcre-8.41. I'll apply it shortly.

@pbogdan
Copy link
Member

pbogdan commented Nov 2, 2017

Nice, I was about to submit https://github.com/NixOS/nixpkgs/compare/master...pbogdan:mongodb-fix-build?expand=1 but didn't realise an upstream patch was available.

@vcunat
Copy link
Member

vcunat commented Nov 2, 2017

master: 0b75c1d + 17.09: d9b0bcc

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants