Conversation
alcaeus
force-pushed
the
feature/fix-artifact-signing
branch
from
a63744e to
575e765
Compare
alcaeus
force-pushed
the
feature/fix-artifact-signing
branch
from
575e765 to
acbdd4d
Compare
alcaeus
force-pushed
the
feature/fix-artifact-signing
branch
from
acbdd4d to
4b6a839
Compare
There was a problem hiding this comment.
Pull request overview
This PR corrects the file path used when creating GPG signatures for Windows PHP MongoDB driver packages. The signing step was previously looking for package files in the wrong directory.
Changes:
- Updated the
filenamesparameter in the GPG signing step to include theartifacts/directory prefix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GromNaN
approved these changes
Jan 28, 2026
This was referenced Jan 28, 2026
Merged
Merged
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 11, 2026
1.21.1 (2025-06-13) What's Changed * PHPC-2558: Update to libmongoc 1.30.3 by @alcaeus in mongodb/mongo-php-driver#1806 * Add CODEOWNERS for 1.21+ by @alcaeus in mongodb/mongo-php-driver#1810 * PHPC-2537 Update to newer Ubuntu version in GitHub Actions workflows by @GromNaN in mongodb/mongo-php-driver#1814 * PHPLIB-1678: Use assume_role command before accessing secrets by @alcaeus in mongodb/mongo-php-driver#1832 * Ignore branches that are no longer maintained when merging up by @alcaeus in mongodb/mongo-php-driver#1838 * PHPC-2593: Update libmongoc to 1.30.5 by @alcaeus in mongodb/mongo-php-driver#1841 1.21.2 (2025-10-07) What's Changed * Fix wrong PHP version constraint for pie by @alcaeus in mongodb/mongo-php-driver#1874 * PHPC-2635: Remove serverless URIs from Atlas connectivity tests by @jmikola in mongodb/mongo-php-driver#1879 * PHPC-2637: Update to libmongoc 1.30.6 by @alcaeus in mongodb/mongo-php-driver#1882 1.21.3 (seems not be released) 1.21.4 (2026-01-28) What's Changed * PHPC-2661: Use php-windows-builder for Windows extension builds by @alcaeus in mongodb/mongo-php-driver#1907 * Refactor release process to support php-windows-builder by @alcaeus in mongodb/mongo-php-driver#1916 * Fix broken release workflow by @alcaeus in mongodb/mongo-php-driver#1919 1.21.5 (2026-02-04) What's Changed * Fix artifact signing by @alcaeus in mongodb/mongo-php-driver#1923 * PHPC-2670: Upgrade libmongoc to 1.30.7 by @alcaeus in mongodb/mongo-php-driver#1930 * PHPC-2636: Respect libbson nesting limit when parsing PHP objects by @alcaeus in mongodb/mongo-php-driver#1934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a wrong path when signing artifacts. I was able to finish the previous test release using a temporary workflow and confirmed that it now works as expected.