CDRIVER-3535 add mongoc_interrupt_t #610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite work for streamable ismaster. Creates a stream which can be safely interrupted from another thread while polling.
kevinAlbs
force-pushed
the
interrupt.CDRIVER-3535
branch
from
c366b5f to
4c8935b
Compare
kevinAlbs
commented
May 12, 2020
| : "0x%08X", exception_code); | ||
| ? "(access violation)" | ||
| : "0x%08X", | ||
| exception_code); |
sgolemon
approved these changes
May 14, 2020
Collaborator
Author
|
Updated. Thanks for the review @sgolemon! |
bazile-clyde
approved these changes
May 20, 2020
Contributor
bazile-clyde
left a comment
bazile-clyde
left a comment
There was a problem hiding this comment.
I left a few comments but otherwise, LGTM.
Collaborator
Author
|
Pushed in 40f8e03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prerequisite work for streamable ismaster.
A mongoc_interrupt_t creates a stream which can be safely interrupted from another thread while polling.
This is needed to support the isMaster Cancellation section. When this is integrated with the work of #607 the interrupt stream will be included in calls to
mongoc_stream_poll, and will be interrupted when shutting down a server monitor.