-
Couldn't load subscription status.
- Fork 148
chore: use concurrently for the build process #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
concurrently allows running independent tasks in parallel in different node.js processes. This can reduce execution time drastically. In my machine it reduces the `npm run check` command execution time to a half. ``` Without concurrently: real 0m20.025s user 0m41.886s sys 0m1.882s With concurrently: real 0m9.910s user 0m59.061s sys 0m2.201s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces concurrently to parallelize independent build and check tasks, reducing execution time by approximately 50% (from ~20s to ~10s on the author's machine). The change optimizes the development workflow by running tasks that don't depend on each other simultaneously.
Key Changes
- Consolidated the
build:chmodcommand intobuild:esmby chaining it with&& - Modified the
buildscript to run ESM, CJS, and universal package builds in parallel usingconcurrently - Modified the
checkscript to run build, type checking, linting, formatting, and dependency checks in parallel
Co-authored-by: Copilot <[email protected]>
Pull Request Test Coverage Report for Build 18721059018Details
💛 - Coveralls |
|
Nice, seems like the reason this works without changing our deps is because |
it seems the inspector uses it, so npm i -D didn't add it in the package.json. Now we mark it explicit.
Yeah, it's weird that npm i -D didn't add the dependency. I've added it manually and pushed the changes. Thanks for noticing it! |
Proposed changes
concurrentlyallows running independent tasks in parallel in different node.js processes. This can reduce execution time drastically. In my machine it reduces thenpm run checkcommand execution time to a half.In GHA, it reduces around 40s the check step (25% faster).
Checklist