Skip to content

Conversation

@kmruiz
Copy link
Collaborator

@kmruiz kmruiz commented Oct 22, 2025

Proposed changes

concurrently allows running independent tasks in parallel in different node.js processes. This can reduce execution time drastically. In my machine it reduces the npm run check command execution time to a half.

Without concurrently:
real	0m20.025s
user	0m41.886s
sys	0m1.882s

With concurrently:
real	0m9.910s
user	0m59.061s
sys	0m2.201s

In GHA, it reduces around 40s the check step (25% faster).

image image

Checklist

concurrently allows running independent tasks in parallel in different
node.js processes. This can reduce execution time drastically. In my
machine it reduces the `npm run check` command execution time to
a half.

```
Without concurrently:
real	0m20.025s
user	0m41.886s
sys	0m1.882s

With concurrently:
real	0m9.910s
user	0m59.061s
sys	0m2.201s
```
Copilot AI review requested due to automatic review settings October 22, 2025 14:31
@kmruiz kmruiz requested a review from a team as a code owner October 22, 2025 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces concurrently to parallelize independent build and check tasks, reducing execution time by approximately 50% (from ~20s to ~10s on the author's machine). The change optimizes the development workflow by running tasks that don't depend on each other simultaneously.

Key Changes

  • Consolidated the build:chmod command into build:esm by chaining it with &&
  • Modified the build script to run ESM, CJS, and universal package builds in parallel using concurrently
  • Modified the check script to run build, type checking, linting, formatting, and dependency checks in parallel

Co-authored-by: Copilot <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18721059018

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.906%

Totals Coverage Status
Change from base Build 18717167438: 0.0%
Covered Lines: 6143
Relevant Lines: 7557

💛 - Coveralls

@gagik
Copy link
Collaborator

gagik commented Oct 22, 2025

Nice, seems like the reason this works without changing our deps is because @modelcontextprotocol/inspector uses it, should we have concurrently as an explicit dev dependency?

it seems the inspector uses it, so npm i -D didn't add it in the
package.json. Now we mark it explicit.
@kmruiz
Copy link
Collaborator Author

kmruiz commented Oct 22, 2025

Nice, seems like the reason this works without changing our deps is because @modelcontextprotocol/inspector uses it, should we have concurrently as an explicit dev dependency?

Yeah, it's weird that npm i -D didn't add the dependency. I've added it manually and pushed the changes. Thanks for noticing it!

@kmruiz kmruiz merged commit c64df57 into main Oct 22, 2025
22 of 24 checks passed
@kmruiz kmruiz deleted the chore/concurrently-check branch October 22, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants