Adding Japanese translation to Mondo #7928
Conversation
…tiative/mondo into japanese-translation
matentzn
changed the title
|
@matentzn is this assigned to me or was my addition only through CODEOWNERS? Also, @sabrinatoro is not assigned to this even though you tagged her about this PR in Slack. |
|
Yes correct, only you can review this (changes are all highly technical), but I am not sure if it's worth your time until we get a decision we want to go ahead with this.. |
|
Ok, let me know when this should be reviewed. |
|
We decided in Slack this should be reviewed and added for the upcoming April release. |
There was a problem hiding this comment.
I ran sh run.sh make translations -B to test this, but ran into this error:
make[1]: *** [Makefile:735: mirror-ncbigene] Error 1
rm imports/foodon_terms.txt imports/omo_terms.txt imports/ncbigene_terms.txt imports/envo_terms.txt imports/ncit_terms.txt
make[1]: Leaving directory '/work/src/ontology'
make: *** [mondo.Makefile:1322: translations] Error 2
|
This goal should be deleted, I only used it during testing. Make mondo-international.owl (with IMP=false etc) |
|
Ok, I will delete the goal |
There was a problem hiding this comment.
I re-ran as sh run.sh make mondo-international.owl IMP=false MIR=false PAT=false -B
Error:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte
make: *** [mondo.Makefile:1334: ../translations/mondo-jp-preprocessed.babelon.tsv] Error 1
|
@matentzn there is an error running the |
|
@matentzn following your email, I re-ran the goal as: However, when I run the goal as: The full logs are attached. Are you able to get the goal to run when using |
@twhetzel sorry about this you were right: the babelon file provided by DBCLS is UTF16 LE encoded which our tools cant handle. I asked them to change this to UTF8, but in the meantime I hack the encoding for the pipeline to work
There was a problem hiding this comment.
With updates to the file from DBCLS (dbcls/mondo-japanese#2) I was able to now run the goal successfully as:
sh run.sh make mondo-international.owl IMP=false MIR=false -B
Some initial experiments adding an international version of Mondo with translations, but mostly for later this year, not now.