Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create page for Phenomics First Resource #210

Closed
Tracked by #265
monicacecilia opened this issue Jul 14, 2023 · 2 comments
Closed
Tracked by #265

Create page for Phenomics First Resource #210

monicacecilia opened this issue Jul 14, 2023 · 2 comments
Labels
frontend

Comments

@monicacecilia
Copy link
Contributor

Create a new page describing the Phenomics First Resource.
Okay to reuse materials from this aging PR as appropriate. monarch-initiative/monarch-ui#406
@sagehrke sagehrke mentioned this issue Jul 18, 2023
Closed
@glass-ships glass-ships mentioned this issue Aug 9, 2023
Merged
7 tasks
@glass-ships
Copy link
Collaborator

A page now exists in the #265 PR, under frontend/src/pages/about/PagePhenomicsFirst.vue
I noticed there are a few incomplete sections - is there anyone knowledgeable enough about PFR to fill in those blanks?

glass-ships added a commit that referenced this issue Aug 18, 2023
@glass-ships @vincerubinetti
Updating About section (#265)
699ab60 
## Related issues

- [x] #210 
- [x] #269 
- [x] #259 
  - [x] Update teams.json
  - [x] Update teams UI
- [x] #232 
- [x] remove Mastodon link 



## Summary

- Added an in-progress Phenomics First page
- Added `scripts/get_publications.py`:
  - Uses `scholarly` to get publications from Google Scholar
- Filters duplicates, known "bad" titles, and titles already in the
existing `publications.json`
- Outputs `new_pubs.json` to be manually curated and added to existing
`publications.json`
- Also gets citation counts (and updates the structure of
`publications.json` to include)
- Publications
  - Used script to update existing `publications.json`
  - Update `PagePublications.vue` to include metadata and graphic
- Teams
  - Updated UI (thanks Vince!)
  - Some updates to members (still waiting on updated QMUL list)

## To Do
- Get remaining team member changes (still need updated list from QMUL I
think)
- ~~Fix frontend tests~~

---------

Co-authored-by: Vincent Rubinetti <[email protected]>
kevinschaper pushed a commit that referenced this issue Aug 22, 2023
@glass-ships @vincerubinetti @kevinschaper
Updating About section (#265)
2c99556 
- [x] #210
- [x] #269
- [x] #259
  - [x] Update teams.json
  - [x] Update teams UI
- [x] #232
- [x] remove Mastodon link

- Added an in-progress Phenomics First page
- Added `scripts/get_publications.py`:
  - Uses `scholarly` to get publications from Google Scholar
- Filters duplicates, known "bad" titles, and titles already in the
existing `publications.json`
- Outputs `new_pubs.json` to be manually curated and added to existing
`publications.json`
- Also gets citation counts (and updates the structure of
`publications.json` to include)
- Publications
  - Used script to update existing `publications.json`
  - Update `PagePublications.vue` to include metadata and graphic
- Teams
  - Updated UI (thanks Vince!)
  - Some updates to members (still waiting on updated QMUL list)

- Get remaining team member changes (still need updated list from QMUL I
think)
- ~~Fix frontend tests~~

---------

Co-authored-by: Vincent Rubinetti <[email protected]>
@vincerubinetti
Copy link
Contributor

Closed by #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@monicacecilia @vincerubinetti @glass-ships