Skip to content

Commit

Permalink
Add leading ; to browser.js
Browse files Browse the repository at this point in the history 
This is a bug in browserify I believe:

browserify/browser-pack#41
browserify/browserify#1351
  • Loading branch information
@mohsen1
mohsen1 committed Oct 29, 2015
1 parent f486d6c commit 48c581b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dist/browser.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 48c581b

@henryptung
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really my place, but would mention that the initial semicolon is defensive; a normal JS file as written by a human probably wouldn't have such a semicolon, so I don't think it makes much sense for browserify to output an initial semicolon. A trailing semicolon though, certainly makes sense; it's proper etiquette for a JS file to properly terminate itself, and not clobber/mangle a following JS file when concatenated.

That said, your dist now seems to begin with -e, which I'm not sure I understand; so I leave the rest up to you.

Please sign in to comment.