Add missing semi-colon when using source maps #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When minifying and concatenating files the missing trailing semi-colon can create side effects resulting in bugs.
|
Ping! Running into this issue right now; this commit seems straightforward enough, but concerned that it doesn't look like it's gotten attention for over a year. See browserify/browserify#1351. Would be happy to chip in to help get this (or another fix) merged. |
|
Ping? |
|
The commit is straightforward, but the consequences are not. Last time I looked at this, there were problems with the standalone option. |
mohsen1
added a commit
to mohsen1/json-to-json-schema
that referenced
this pull request
Oct 29, 2015
This is a bug in browserify I believe: browserify/browser-pack#41 browserify/browserify#1351
|
@zertosh Can you provide a repro or description of the case you ran into? May be able to take a look if I have a place to start from. Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When minifying and concatenating files the missing trailing semi-colon can create side effects resulting in bugs.