Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Sweep experiments older than 2023-05-01 #435

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on May 1, 2024

  1. (2021-01-20, a9e2778) adsense-ad-size-optimization: 1

    Previous history on prod-config.json:
    
    - a9e2778 - 2021-01-20T20:47:24+00:00 - Ramp up the adsense-ad-size-optimization experiment to 100%.
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    563dfc4 View commit details
    Browse the repository at this point in the history
  2. (2020-11-19, cac0248) amp-accordion-display-locking: 1

    Previous history on prod-config.json:
    
    - cac0248 - 2020-11-19T12:26:09-05:00 - Increase from 10% to 100%
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    87fb5eb View commit details
    Browse the repository at this point in the history
  3. (2020-08-14, 77ced1d) expand-json-targeting: 1

    Previous history on prod-config.json:
    
    - 77ced1d - 2020-08-14T15:52:39-07:00 - Ramp json targeting expansion experiment to 100%
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    85cd1ad View commit details
    Browse the repository at this point in the history
  4. (2021-01-27, b738789) visibility-trigger-improvements: 1

    Previous history on prod-config.json:
    
    - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1%
    - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)"
    - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ed7c4de View commit details
    Browse the repository at this point in the history
  5. (2021-03-05, 77127c7) disable-a4a-non-sd: 1

    Previous history on prod-config.json:
    
    - 77127c7 - 2021-03-05T09:36:06-08:00 - Turn on backupCid experiment in prod
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ae3cfbf View commit details
    Browse the repository at this point in the history
  6. (2021-03-12, 1b7583d) tcf-post-message-proxy-api: 1

    Previous history on prod-config.json:
    
    - 1b7583d - 2021-03-12T07:22:55-08:00 - 🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a1cbd62 View commit details
    Browse the repository at this point in the history
  7. (2021-03-17, db781bd) amp-consent-granular-consent: 1

    Previous history on prod-config.json:
    
    - db781bd - 2021-03-17T09:35:48-07:00 - turnOnGranularConsent
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    07862dc View commit details
    Browse the repository at this point in the history
  8. (2021-03-23, 1115f6c) amp-cid-backup: 1

    Previous history on prod-config.json:
    
    - 1115f6c - 2021-03-23T03:46:29+08:00 - Ramp up 3p-vendor-split experiment
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    106c8ad View commit details
    Browse the repository at this point in the history
  9. 🚮 Sweep experiments older than 2023-05-01

    Sweep experiments last flipped globally up to 2023-05-01:
    
    - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
    - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
    - (2020-08-14, 77ced1d) `expand-json-targeting`: 1
    - (2021-01-27, b738789) `visibility-trigger-improvements`: 1
    - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
    - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
    - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
    - (2021-03-23, 1115f6c) `amp-cid-backup`: 1
    
    ---
    
    ### Cleanup issues
    
    Close these once they've been addressed and this PR has been merged:
    
    - [ ] `adsense-ad-size-optimization`: ampproject#24165
    - [ ] `visibility-trigger-improvements`: ampproject#26823
    - [ ] `amp-cid-backup`: ampproject#29484
    
    ---
    
    ### ⚠️ Javascript source files require intervention
    
    The following may contain errors and/or require intervention to remove superfluous conditionals:
    
    - [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
    - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
    - [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
    - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
    - [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
    - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
    - [ ] `extensions/amp-analytics/0.1/analytics-root.js`
    - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
    - [ ] `extensions/amp-analytics/0.1/test/test-events.js`
    - [ ] `extensions/amp-consent/0.1/amp-consent.js`
    - [ ] `extensions/amp-consent/0.1/consent-ui.js`
    - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
    - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
    - [ ] `src/custom-element.js`
    - [ ] `src/service/cid-impl.js`
    - [ ] `test/unit/test-custom-element.js`
    
    Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)
    
    ---
    
    ### ⚠️ HTML files may still contain references
    
    The following HTML files contain references to experiment names which may be stale and should be manually removed:
    
    - [ ] `examples/accordion.amp.html`
    - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
    - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
    - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`
    
    Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
    mohammed-ibra committed May 1, 2024
    Configuration menu
    Copy the full SHA
    36be40a View commit details
    Browse the repository at this point in the history