fix(react-bridge): correct react-router-dom peer dependency#3604
Merged
zackarychapple merged 1 commit intomodule-federation:mainfrom Mar 18, 2025
Merged
fix(react-bridge): correct react-router-dom peer dependency#3604zackarychapple merged 1 commit intomodule-federation:mainfrom
zackarychapple merged 1 commit intomodule-federation:mainfrom
Conversation
Update peerDependency for react-router-dom to point to the version of React Router that is compatible with react-router-dom 7. I did some tests and have already been using react-router-dom v7 with the Bridgea, and I haven't had any issues with the routing.
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ScriptedAlchemy
approved these changes
Mar 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update peerDependency for react-router-dom to point to the version of React Router that is compatible with react-router-dom 7.
I did some tests and have already been using react-router-dom v7 with the Bridgea, and I haven't had any issues with the routing.
Description
Related Issue
Types of changes
Checklist