Skip to content

fix(react-bridge): correct react-router-dom peer dependency#3604

Merged
zackarychapple merged 1 commit intomodule-federation:mainfrom
douglaszaltron:patch-2
Mar 18, 2025
Merged

fix(react-bridge): correct react-router-dom peer dependency#3604
zackarychapple merged 1 commit intomodule-federation:mainfrom
douglaszaltron:patch-2

Conversation

@douglaszaltron
Copy link
Contributor

Update peerDependency for react-router-dom to point to the version of React Router that is compatible with react-router-dom 7.

I did some tests and have already been using react-router-dom v7 with the Bridgea, and I haven't had any issues with the routing.

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Update peerDependency for react-router-dom to point to the version of React Router that is compatible with react-router-dom 7.

I did some tests and have already been using react-router-dom v7 with the Bridgea, and I haven't had any issues with the routing.
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 4eedf03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 4eedf03
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67d86d724caa37000837d143
😎 Deploy Preview https://deploy-preview-3604--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zackarychapple zackarychapple merged commit 18551d3 into module-federation:main Mar 18, 2025
15 checks passed
@2heal1 2heal1 mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants