fix(vue3-bridge): correct vue-router peer dependency

[thedamon]

Update peerDependency for vue3-bridge to point to the version of Vue Router that is compatible with Vue 3.

Closes #3567

Description

Updated vue-router peerDependency from 3 to 4.
This allows installing the package with npm without having to pass in --legacy-peer-deps.

Related Issue

#3567

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the documentation.

[changeset-bot]

⚠️ No Changeset found

Latest commit: fa347c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	fa347c3
🔍 Latest deploy log	https://app.netlify.com/sites/module-federation-docs/deploys/67da3a221f0c6c0008bf9821
😎 Deploy Preview	https://deploy-preview-3603--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ScriptedAlchemy]

Should we support 3 || 4 to support both?

[thedamon]

Vue router 3 is only for Vue 2 so I figured 4 made sense. Not sure if this component works with Vue 2 but the name implies it’s not meant to.

…

On Mon, Mar 17, 2025 at 22:50 Zack Jackson ***@***.***> wrote: Should we support 3 || 4 to support both? — Reply to this email directly, view it on GitHub <#3603 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKPYI3G5JHUZFDZL6BSW732U6CW5AVCNFSM6AAAAABZGHRT5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZRGQ3DOMJWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: ScriptedAlchemy]*ScriptedAlchemy* left a comment (module-federation/core#3603) <#3603 (comment)> Should we support 3 || 4 to support both? — Reply to this email directly, view it on GitHub <#3603 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKPYI3G5JHUZFDZL6BSW732U6CW5AVCNFSM6AAAAABZGHRT5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZRGQ3DOMJWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[thedamon]

Should we support 3 || 4 to support both?

To follow up on my last reply, looking at the sourcecode it's using useRoute which is specifically from vue-router v4 not v3, so I think it should be locked to 4

[danpeen]

@thedamon Vue Router v4 and v3 are not compatible. They have some significant differences that make them incompatible with each other. How about we set like this:

"peerDependencies": {
  "vue": "^2.0.0 || ^3.0.0",
  "vue-router": "^3.0.0 || ^4.0.0"
}

[thedamon]

@thedamon Vue Router v4 and v3 are not compatible. They have some significant differences that make them incompatible with each other. How about we set like this:

"peerDependencies": {
  "vue": "^2.0.0 || ^3.0.0",
  "vue-router": "^3.0.0 || ^4.0.0"
}

I think the code of this repo itself, as well as the naming, is such that it would only be compatible with vue 3 + vue-router 4. I think using it with vue-router 3 would break. I would respect the version of vue-router already present in the devDependencies, which is 4.

[danpeen]

@thedamon Makes sense. I think only if we need to support vue2 could we make this compatible change.

[yaseiva]

I was hoping you would fix react-router at the same time.

warning " > @module-federation/bridge-react@0.10.0" has incorrect peer dependency "react-router-dom@^4 || ^5 || ^6"

We are on v7 now, you want me to create a issue for this?

[MaksSieve]

whe we will see a package with thi changes? this error blocks us from using module federation at all :(