Skip to content

feat: add zephyr options to CLI#3571

Merged
zackarychapple merged 8 commits intomodule-federation:feat/create-module-federationfrom
Nsttt:feat/add-zephyr
Mar 7, 2025
Merged

feat: add zephyr options to CLI#3571
zackarychapple merged 8 commits intomodule-federation:feat/create-module-federationfrom
Nsttt:feat/add-zephyr

Conversation

@Nsttt
Copy link
Contributor

@Nsttt Nsttt commented Mar 5, 2025

Description

Add support for Zephyr templates in the create-module-federation CLI @2heal1

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 2c206e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nsttt Nsttt marked this pull request as ready for review March 5, 2025 19:08
@2heal1
Copy link
Member

2heal1 commented Mar 6, 2025

Thanks for contributing ! Thinking there may be more custom templates , i will support using theirself cli like vite .

After i finish it , you can adjust this pr to merge

@2heal1
Copy link
Member

2heal1 commented Mar 6, 2025

Can you create new cli like create-zephy ? MF cli will exec this command https://github.com/module-federation/core/pull/3446/files#diff-466c8fad51de5063a00ad9a5dc2a52553abfbaf5d18eea5a890dc752afe15cc0R435

@Nsttt
Copy link
Contributor Author

Nsttt commented Mar 6, 2025

Sure, I'll ping you once I have it 😄

@zmzlois
Copy link

zmzlois commented Mar 6, 2025

Can you create new cli like create-zephy ? MF cli will exec this command https://github.com/module-federation/core/pull/3446/files#diff-466c8fad51de5063a00ad9a5dc2a52553abfbaf5d18eea5a890dc752afe15cc0R435

we have create-zephyr-apps want us to add it there yeah?

@Nsttt
Copy link
Contributor Author

Nsttt commented Mar 6, 2025

Added a fallback into our CLI so we don't add even more examples everywhere @2heal1 have a look and tell me if you like it 😄

@2heal1
Copy link
Member

2heal1 commented Mar 7, 2025

got, i need to talk more detail with @ScriptedAlchemy

@zackarychapple zackarychapple merged commit d040869 into module-federation:feat/create-module-federation Mar 7, 2025
2heal1 pushed a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants