Skip to content

fix(rsbuild-plugin): export type ModuleFederationOptions#3414

Merged
ScriptedAlchemy merged 4 commits into
module-federation:mainfrom
douglaszaltron:patch-1
Jan 1, 2025
Merged

fix(rsbuild-plugin): export type ModuleFederationOptions#3414
ScriptedAlchemy merged 4 commits into
module-federation:mainfrom
douglaszaltron:patch-1

Conversation

@douglaszaltron

@douglaszaltron douglaszaltron commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

Description

A better approach for configuration is to create a separate file with more robust typing. Since we don't have a direct export, we can type the file by obtaining its definitions. When exporting types, we gain the flexibility to import them as needed.

This way, we can achieve better configuration through a dedicated module-federation.config.ts file.

This approach brings the following benefits:

  • Better code organization
  • Safer and more explicit typing
  • Clear separation between configuration and implementation
  • Easier maintenance and type reusability

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot

changeset-bot Bot commented Dec 26, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 893a3a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Dec 26, 2024

Copy link
Copy Markdown

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 893a3a8
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6774853167d5db0008f1ecc7
😎 Deploy Preview https://deploy-preview-3414--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@douglaszaltron douglaszaltron changed the title fix: export type ModuleFederationOptions fix(rsbuild-plugin): export type ModuleFederationOptions Dec 26, 2024
@ScriptedAlchemy ScriptedAlchemy merged commit 60a4b28 into module-federation:main Jan 1, 2025
@KyrieLii KyrieLii mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants