[stm32] Fix linkerscript veneer offset issues #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
force-pushed
the
fix/linker
branch
2 times, most recently
from
81340c9 to
1b41daf
Compare
|
I still need to validate this for all other devices, so not merging yet. |
salkinium
approved these changes
Oct 23, 2021
salkinium
added
ci:hal
|
Validated in hardware on all linkerscripts variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a linkerscript bug that can cause code placed in RAM to be loaded to the wrong address because alignment is ignored. By chance the bug showed on some F0/L0 after the
deletestub implementations were added 9 days ago.We could reproduce the bug with the blink examples on F042, F030 and L031 devices but more devices are affected. It caused the delay to run with random durations. The instructions loading
modm::platform::delay_fcpu_MHzfrom ram to a register were never executed.This bug was most likely introduced in the last linkerscript refactoring in July.
Thanks to @salkinium for coming up with the fix after it was clear what the issue was.