Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMA for even more STM32 controllers (F4, F7) #629

Merged
merged 2 commits into from
Oct 28, 2021
Merged

DMA for even more STM32 controllers (F4, F7) #629

merged 2 commits into from
Oct 28, 2021

Conversation

rleh
Copy link
Member

@rleh rleh commented May 9, 2021

Compiles but does not work yet...

@rleh rleh mentioned this pull request May 9, 2021
Closed
@rleh
Copy link
Member Author

rleh commented May 27, 2021

I've been very busy with other stuff in the last two weeks, I hope at the weekend or next week I find time to continue here.

@rleh rleh added the stale ♾ label Oct 20, 2021
@rleh rleh force-pushed the feature/dma_f4_f7 branch from e154b5d to c0e36f4 Compare October 24, 2021 21:42
@rleh rleh removed the stale ♾ label Oct 24, 2021
@rleh rleh added this to the 2021q4 milestone Oct 26, 2021
@rleh rleh force-pushed the feature/dma_f4_f7 branch from b0857fd to e8f2aa4 Compare October 26, 2021 17:24
@rleh rleh marked this pull request as ready for review October 26, 2021 20:03
@rleh
Copy link
Member Author

rleh commented Oct 26, 2021

Todo: Test if the other DMA examples are still working.

@rleh
Copy link
Member Author

rleh commented Oct 26, 2021

Todo: Test if the other DMA examples are still working.

I will test the other existing DMA examples, do code cleanup, add copyright notices and squash commits tomorrow.
Feel free to review!

@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Oct 27, 2021
salkinium
salkinium approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand it, but I also don't disagree with it. The DMA data set could use an exorcist tho.

@rleh rleh removed the ci:hal Triggers the exhaustive HAL compile CI jobs label Oct 27, 2021
@rleh rleh force-pushed the feature/dma_f4_f7 branch from c28bb51 to b8a8a28 Compare October 27, 2021 16:02
chris-durand
chris-durand approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

src/modm/platform/dma/stm32/module.lb Outdated Show resolved Hide resolved
src/modm/platform/dma/stm32/dma_hal.hpp.in Outdated Show resolved Hide resolved
@rleh rleh force-pushed the feature/dma_f4_f7 branch from b8a8a28 to 5dcdf1d Compare October 28, 2021 12:41
@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Oct 28, 2021
@rleh rleh merged commit 5dcdf1d into modm-io:develop Oct 28, 2021
@rleh rleh deleted the feature/dma_f4_f7 branch October 28, 2021 14:05
@rleh rleh restored the feature/dma_f4_f7 branch October 28, 2021 14:12
@rleh rleh deleted the feature/dma_f4_f7 branch October 29, 2021 18:03
@rleh rleh mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Milestone
2021q4
Development

Successfully merging this pull request may close these issues.
3 participants
@rleh @salkinium @chris-durand