Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rcc:PllSource for some STM32F3 devices and add Nucleo-F334R8 board #489

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Fix Rcc:PllSource for some STM32F3 devices and add Nucleo-F334R8 board #489

merged 3 commits into from
Oct 6, 2020

Conversation

rleh
Copy link
Member

@rleh rleh commented Oct 6, 2020

@hshose discovered that there is no Hsi element in Rcc::PllSource on STM32F373 devices, d89c06e should fix it.

Sadly there is no STM32F373 Nucleo or Discovery board, but I found a Nucleo-F334R8 board in my dev-board box, so I added it to modm.

@rleh rleh requested a review from salkinium October 6, 2020 00:50
salkinium
salkinium approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium merged commit 85eec34 into modm-io:develop Oct 6, 2020
@rleh rleh deleted the board/nucleo_f334r8 branch October 6, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
example 🔑 fix 💎
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rleh @salkinium