fix(dev-server-rollup): fix rollup adapter resolution for virtual modules on Windows #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules on Windows close modernweb-dev#2078
🦋 Changeset detectedLatest commit: 712e5fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt to close #2078 (with #2079 being the first attempt).
The issue is that an absolute Windows path prefixed with a null byte is not a valid absolute file path, but it is (apparently) a valid URL (the null byte gets eaten as white space, and then the
C:is interpreted as the URL scheme). However, in the context of processing Rollup plugins, the null byte is a signal that this path should be treated in a special way.This fix explicitly checks for the null byte to avoid this issue, as discussed with @giamir and @43081j.