[RaphaelFakhri]

PR Checklist

• Addresses an existing open issue: fixes unloadFiles throws MODULE_NOT_FOUND in ESM context for files added with relative path #4548
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Mocha#loadFiles resolves each file with path.resolve(), so relative paths are relative to the current working directory. Mocha.unloadFile passes the path straight to a require.resolve created in lib/nodejs/, so a relative path resolves from there instead. Since #6355, the resulting MODULE_NOT_FOUND is swallowed, so the file silently stays in the require cache and the next run registers no tests:

const mocha = new Mocha();
mocha.addFile("test/a.spec.js");
mocha.run(() => {
  mocha.unloadFiles();
  mocha.run(); // 0 passing
});

This change resolves the path with path.resolve() before require.resolve(), matching loadFiles. Absolute paths, which watch mode uses, are unchanged.

A new unit test in test/node-unit/mocha.spec.cjs unloads a file by its cwd-relative path. It fails without the fix and passes with it. npm run test-node:unit and the watch integration tests pass.

This picks up the fix from #4549 and #6259, which were closed before review.

[linux-foundation-easycla]

• ❌ - login: @RaphaelFakhri / name: Raphael Fakhri. The commit (c763336) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

[github-actions]

Automation signals

Activity patterns show signs of automation.

View full analysis →

Report this account →

Evidence

• Extreme fork automation: 60 repositories forked in rapid succession (within 24 hours)
• Very high PR volume (daily): 62 PRs within a single 24-hour window
• High PR volume (weekly): 62 PRs within a single 7-day window

Last 5 PRs:

• https://github.com/tokio-rs/mio/pull/2038
• https://github.com/swiftlang/swift-book/pull/503
• https://github.com/tokio-rs/turmoil/pull/302
• https://github.com/typelevel/jawn/pull/801
• https://github.com/typelevel/toolkit/pull/367

_{This is an automated analysis by AgentScan}