Repository navigation
Conversation
Co-authored-by: Christian Lewis <ctjl96@gmail.com>
|
|
Author
|
Closing because I’m stepping back from maintaining this contribution. Thanks for your time. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
addFile()keeps paths exactly as supplied, and Mocha loads relative paths from the current working directory.unloadFile()instead passed those paths directly torequire.resolve(), which resolved them relative tolib/nodejs/file-unloader.cjsand threwMODULE_NOT_FOUND.Resolve the file path from the current working directory before looking up its cache key. The regression test loads a fixture, adds it using a cwd-relative path, and verifies that
unloadFiles()removes it fromrequire.cache.The commit includes co-author attribution for the original implementation in #4549.
Validation
npm run test-node:unit— 1220 passing, 3 pendingFixes #4548