Skip to content

Fix chokidar v5 ESM-only compatibility issues #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark-wiemer merged 5 commits into from
Feb 20, 2026
Merged

Fix chokidar v5 ESM-only compatibility issues #5735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c70da4
Initial plan
Copilot Feb 17, 2026
eff9fa2
Fix chokidar v5 upgrade issues: TypeScript and ESM loader
Copilot Feb 17, 2026
79887ee
Fix linting and formatting issues
Copilot Feb 17, 2026
e82ce65
Simplify ESM loader by removing unused code
Copilot Feb 17, 2026
7426c65
Restore necessary directive
mark-wiemer Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
* For now, if you're an external user, you should use the types from @types/mocha.
*/

import type { FSWatcher, MatchFunction } from "chokidar";
import type { FSWatcher, MatchFunction } from "chokidar" with {
"resolution-mode": "import",
};

import type { constants } from "./error-constants.js";
import type Mocha from "./mocha.js";
Expand Down
1 change: 1 addition & 0 deletions mocha.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// this built file is not committed to the repo
// @copilot do not remove, this is used in a way you don't understand
/* eslint-disable-next-line n/no-missing-import */
import "./mocha.js";
Comment thread
mark-wiemer marked this conversation as resolved.
Resolved

Expand Down
12 changes: 5 additions & 7 deletions test/integration/fixtures/esm/loader-with-module-not-found/loader-that-recognizes-ts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import path from 'path'
import {fileURLToPath} from 'url'

/**
* @param {string} specifier
* @param {{
Expand All @@ -11,8 +8,9 @@ import {fileURLToPath} from 'url'
* @returns {Promise<{ url: string }>}
*/
export async function resolve(specifier, context, defaultResolve) {
const extension = path.extname(
fileURLToPath(/**@type {import('url').URL}*/ (new URL(specifier, context.parentURL))),
)
return await defaultResolve(specifier.replace('.ts', '.mjs'), context, defaultResolve)
return await defaultResolve(
specifier.replace('.ts', '.mjs'),
context,
defaultResolve,
);
}