Repository navigation
Fix chokidar v5 ESM-only compatibility issues - #5735
Merged
Merged
Conversation
1 task
|
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix update dependency chokidar to v5
Fix chokidar v5 ESM-only compatibility issues
Feb 17, 2026
Member
|
Requested workflow run: https://github.com/mochajs/mocha/actions/runs/22207566379 |
Member
|
Tests pass except for lint lol, silly bot keeps removing an ESLint directive. |
mark-wiemer
reviewed
Feb 20, 2026
mark-wiemer
marked this pull request as ready for review
February 20, 2026 01:46
mark-wiemer
added a commit
that referenced
this pull request
Feb 21, 2026
* fix(deps): update dependency chokidar to v5 * Fix chokidar v5 ESM-only compatibility issues (#5735) * Initial plan * Fix chokidar v5 upgrade issues: TypeScript and ESM loader Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> * Fix linting and formatting issues Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> * Simplify ESM loader by removing unused code Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> * Restore necessary directive --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chokidar v5 transitioned to ESM-only, breaking TypeScript compilation and an integration test that uses an ESM loader.
Changes
TypeScript import fix: Added
with { "resolution-mode": "import" }attribute to chokidar import inlib/types.d.ts. Required for Node16 module resolution when importing ESM from CommonJS context.ESM loader test fix: Simplified
loader-that-recognizes-ts.mjsby removing unusedfileURLToPath()call that was throwingERR_INVALID_URL_SCHEMEfor bare module specifiers before the expectedERR_MODULE_NOT_FOUNDcould occur.Lint cleanup: Removed obsolete
eslint-disabledirective inmocha.mjsthat became unnecessary with the chokidar update.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.