fix: Add error handling for nonexistent file case with --file option #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added error handling when using the --file flag to do it the way --require does - added a test to assert that we throw the same type of error
|
|
khoaHyh
changed the title
- require.resolve() by Node.js follows a Node.js module resolution algo which includes checking if the resolved path actually exists on the file system.
JoshuaKGoldberg
requested changes
Mar 4, 2024
JoshuaKGoldberg
added
the
status: waiting for author
khoaHyh
commented
Mar 24, 2024
khoaHyh
commented
May 29, 2024
There was a problem hiding this comment.
@JoshuaKGoldberg tagging for re-review just in case this disappeared into the backlog abyss 😅
This was referenced Sep 18, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 Overview
Fixes #4047
--fileoption by resolving the argument to an absolute path and check for its existence. We now log a warning and exit if the file does not exist.--requirebubble up to the middleware inlib/cli/run.js. See here. This specific error occurs inlib/cli/run-helpers.jsin thesingleRunmethod when we load files asynchronously. Since we were lacking error handling there, the errors appeared the way they previously did before these changes.