refactor: log warning and remove call stack

mochajs · Feb 7, 2024 · 9b3d5d2 · 9b3d5d2
1 parent b6d6dc2
commit 9b3d5d2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/bin/mocha.js b/bin/mocha.js
diff --git a/lib/cli/collect-files.js b/lib/cli/collect-files.js
@@ -60,8 +60,11 @@ module.exports = ({
       require.resolve(fileAbsolutePath);
     } catch (err) {
       // this error doesn't bubble up to the middleware like how
-      // --require handles it so we have to do it here
-      console.error(`\n${symbols.error} ${ansi.red('ERROR:')}`, err);
+      // --require handles it so we log a warning here and exit
+      const warningMessage = ansi.yellow(
+        `${symbols.warning} Warning: Cannot find test file "${file}" at the path "${fileAbsolutePath}"`
+      );
+      console.warn(`${warningMessage}\n`);
       process.exit(1);
     }
   });

diff --git a/test/integration/options/file.spec.js b/test/integration/options/file.spec.js
@@ -67,7 +67,7 @@ describe('--file', function () {
     });
   });
 
-  it('should throw an ERR_MODULE_NOT_FOUND if a nonexistent file is specified', function (done) {
+  it('should log a warning if a nonexistent file is specified', function (done) {
     runMocha(
       'esm/type-module/test-that-imports-non-existing-module.fixture.js',
       ['--file'],
@@ -76,7 +76,7 @@ describe('--file', function () {
           return done(err);
         }
 
-        expect(res.output, 'to contain', 'ERR_MODULE_NOT_FOUND').and(
+        expect(res.output, 'to contain', 'Warning: Cannot find test file').and(
           'to contain',
           'test-that-imports-non-existing-module'
         );