Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint all the things #2525

Closed
boneskull opened this issue Oct 10, 2016 · 0 comments
Closed

lint all the things #2525

boneskull opened this issue Oct 10, 2016 · 0 comments
Assignees
@boneskull

Comments

@boneskull
Copy link
Contributor

semistandard is in place; I'm going to fix the rest of the issues across the codebase in skipped files.

currently we're skipping the tests (which are a mess). there's also a few other issues (such as strict mode) scattered about.
@boneskull boneskull added the qa label Oct 10, 2016
@boneskull boneskull self-assigned this Oct 10, 2016
boneskull added a commit that referenced this issue Oct 10, 2016
@boneskull
lint the hell out of the javascript; closes #2525
c21e380 
- mostly whitespace changes
- add `'use strict';` everywhere
- fix problems with unused variables, bad variable names, multiple declarations, unreachable code, yoda expressions, error handling, instantiation, etc.
- add a few eslint directives to avoid rules when needed
- switch to YAML eslint configs
- remove `test/` from `.eslintignore`
- add `mocha.js` to `.eslintignore`
- add userland `assert` as dev dependency (as is recommended)
- rename `test/fixture-expect.js` to `test/setup.js`; add global `assert` here
- add `assert` and `run` globals to `test/`'s eslint config
- update `test/mocha.opts` as appropriate
- update `lint` target in `Makefile`
- update eslint environments as appropriate
This was referenced Sep 23, 2018
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this issue Oct 4, 2018
Closed
1 task
@renovate renovate bot mentioned this issue Nov 14, 2018
Merged
@renovate renovate bot mentioned this issue Nov 23, 2018
Merged
@renovate renovate bot mentioned this issue Dec 7, 2018
Merged
1 task
This was referenced Dec 23, 2018
Closed
Closed
sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019
@boneskull
lint the hell out of the javascript; closes mochajs#2525
791f6c6 
- mostly whitespace changes
- add `'use strict';` everywhere
- fix problems with unused variables, bad variable names, multiple declarations, unreachable code, yoda expressions, error handling, instantiation, etc.
- add a few eslint directives to avoid rules when needed
- switch to YAML eslint configs
- remove `test/` from `.eslintignore`
- add `mocha.js` to `.eslintignore`
- add userland `assert` as dev dependency (as is recommended)
- rename `test/fixture-expect.js` to `test/setup.js`; add global `assert` here
- add `assert` and `run` globals to `test/`'s eslint config
- update `test/mocha.opts` as appropriate
- update `lint` target in `Makefile`
- update eslint environments as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boneskull boneskull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boneskull