lint the hell out of the javascript; closes mochajs#2525

- mostly whitespace changes
- add `'use strict';` everywhere
- fix problems with unused variables, bad variable names, multiple declarations, unreachable code, yoda expressions, error handling, instantiation, etc.
- add a few eslint directives to avoid rules when needed
- switch to YAML eslint configs
- remove `test/` from `.eslintignore`
- add `mocha.js` to `.eslintignore`
- add userland `assert` as dev dependency (as is recommended)
- rename `test/fixture-expect.js` to `test/setup.js`; add global `assert` here
- add `assert` and `run` globals to `test/`'s eslint config
- update `test/mocha.opts` as appropriate
- update `lint` target in `Makefile`
- update eslint environments as appropriate

Author: boneskull

.eslintignore

@@ -1,3 +1,2 @@
-lib/to-iso-string/
-test/**/*
-!test/runner.js
+lib/to-iso-string/**/*.js
+mocha.js

.eslintrc.js

@@ -0,0 +1,11 @@
+env:
+  node: true
+  browser: true
+parserOptions:
+  ecmaVersion: 5
+  sourceType: script
+extends: semistandard
+rules:
+  strict:
+    - error
+    - safe

.eslintrc.yaml

@@ -25,7 +25,7 @@ clean:
 
 lint:
 	@printf "==> [Test :: Lint]\n"
-	$(ESLINT) browser-entry.js index.js karma.conf.js bin/mocha bin/_mocha "lib/**/*.js" "scripts/**/*.js" test
+	$(ESLINT) .
 
 test-node: test-bdd test-tdd test-qunit test-exports test-unit test-integration test-jsapi test-compilers test-glob test-requires test-reporters test-only test-global-only
 

Makefile

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+'use strict';
 
 /* eslint no-unused-vars: off */
 

bin/_mocha

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 /**
  * This tiny wrapper file checks for known node flags and appends them
  * when found, before invoking the "real" _mocha(1) executable.

bin/mocha

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Dependencies.
  */
@@ -14,17 +16,17 @@ module.exports = getOptions;
  * Get options.
  */
 
-function getOptions() {
-  var optsPath = process.argv.indexOf('--opts') !== -1
-        ? process.argv[process.argv.indexOf('--opts') + 1]
-        : 'test/mocha.opts';
+function getOptions () {
+  var optsPath = process.argv.indexOf('--opts') === -1
+    ? 'test/mocha.opts'
+    : process.argv[process.argv.indexOf('--opts') + 1];
 
   try {
     var opts = fs.readFileSync(optsPath, 'utf8')
       .replace(/\\\s/g, '%20')
       .split(/\s/)
       .filter(Boolean)
-      .map(function(value) {
+      .map(function (value) {
         return value.replace(/%20/g, ' ');
       });
 

bin/options.js

@@ -1,4 +1,7 @@
+'use strict';
+
 /* eslint no-unused-vars: off */
+/* eslint-env commonjs */
 
 /**
  * Shim process.stdout.

browser-entry.js

@@ -0,0 +1,4 @@
+env:
+  node: false
+  browser: false
+  commonjs: true

lib/browser/.eslintrc.yaml

@@ -1,4 +1,7 @@
-/* eslint-disable no-unused-vars */
-module.exports = function (type) {
-  return function () {};
+'use strict';
+
+function noop () {}
+
+module.exports = function () {
+  return noop;
 };

lib/browser/debug.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module exports.
  */

lib/browser/events.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Expose `Progress`.
  */

lib/browser/progress.js

@@ -1,3 +1,5 @@
+'use strict';
+
 exports.isatty = function isatty () {
   return true;
 };

lib/browser/tty.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/context.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/hook.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/interfaces/bdd.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/interfaces/exports.js

@@ -1,3 +1,5 @@
+'use strict';
+
 exports.bdd = require('./bdd');
 exports.tdd = require('./tdd');
 exports.qunit = require('./qunit');

lib/interfaces/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/interfaces/qunit.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/interfaces/tdd.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*!
  * mocha
  * Copyright(c) 2011 TJ Holowaychuk <[email protected]>

lib/mocha.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Helpers.
  */

lib/ms.js

@@ -1,3 +1,4 @@
+'use strict';
 
 /**
  * Expose `Pending`.

lib/pending.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/base.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/doc.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/dot.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /* eslint-env browser */
 
 /**

lib/reporters/html.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // Alias exports to a their normalized format Mocha#reporter to prevent a need
 // for dynamic (try/catch) requires, which Browserify doesn't handle.
 exports.Base = exports.base = require('./base');

lib/reporters/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/json-stream.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/json.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/landing.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/list.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/markdown.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/min.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/nyan.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/progress.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/spec.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/tap.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/reporters/xunit.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/runnable.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/runner.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/suite.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Module dependencies.
  */

lib/test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /* eslint-env browser */
 
 /**

lib/utils.js

@@ -314,6 +314,7 @@
     "supports-color": "3.1.2"
   },
   "devDependencies": {
+    "assert": "^1.4.1",
     "browserify": "^13.0.0",
     "coffee-script": "^1.10.0",
     "eslint": "^2.13.1",

package.json

@@ -0,0 +1,7 @@
+env:
+  mocha: true
+globals:
+  expect: false
+  assert: false
+  # https://github.com/sindresorhus/globals/pull/102
+  run: false