-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate flow types #676
generate flow types #676
Conversation
@A-gambit thanks! I think the overloads for |
@mweststrate Yep. I will do it later on this week. |
@mweststrate I review types and fix some bugs. |
@A-gambit cool, thanks! So this is ready to be added as first version of flow support? |
@@ -17,6 +17,7 @@ | |||
"test-browser-safari": "npm run small-build && ( browserify test/*.js -t [ babelify --presets [ es2015 ] ] | tape-run --browser safari )", | |||
"test-browser-firefox": "npm run small-build && ( browserify test/*.js | tape-run --browser firefox )", | |||
"test-travis": "npm run small-build && npm run build-tests && tape test/*.js test/perf/index.js && tsc && istanbul cover tape test/*.js", | |||
"test-flow": "node_modules/.bin/flow check", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should be invoked from test-travis
and full-test
@mweststrate Sure. I have just add flow check to test scripts. |
@mweststrate So, I can merge? |
yep. should we merge it to just mobx3 branch or also to master? v3 should
come out in the next days
Op ma 28 nov. 2016 13:55 schreef Gregory Shehet <[email protected]>:
… @mweststrate <https://github.com/mweststrate> So, I can marge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#676 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhBu91oVljE3_nr4ivinDFYYbiRT5ks5rCs9LgaJpZM4K4V_d>
.
|
@mweststrate Ok, I will merge it to v3, and add new v3 methods to flow types. I think it will be better. |
@mweststrate Done. Can I merge? |
yes! don't forget to update changelog.md. great work, much appreciated!
Op ma 28 nov. 2016 17:04 schreef Gregory Shehet <[email protected]>:
… @mweststrate <https://github.com/mweststrate> Done. Can I merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#676 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhKbyeGqIJm3KAia0Xqk_zj7I8GQfks5rCvuLgaJpZM4K4V_d>
.
|
Issue #640
Provide flow types, using typedef-converter.
Please review, @mweststrate.