Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide flow typings #640

Closed
mweststrate opened this issue Nov 2, 2016 · 5 comments
Closed

Provide flow typings #640

mweststrate opened this issue Nov 2, 2016 · 5 comments
Assignees

Comments

@mweststrate
Copy link
Member

MobX ships with typescript typings. However, flow people are regularly asking for these typings as well. It would be nice to add these typings as well.

Some questions:

  1. can the conversion be automated? see e.g. https://github.com/Kegsay/ProbablyFlowTyped
  2. can the typings be maintained in this repo, or do they need to be stored in the flow typings registry?
  3. what about mobx-react / mobx-util?

PR's are welcome!

@A-gambit
Copy link
Member

@mweststrate I need it in my project. I can do it the next time.

@mweststrate
Copy link
Member Author

Awesome, looking forward!

@mweststrate
Copy link
Member Author

@A-gambit
Copy link
Member

A-gambit commented Nov 21, 2016

@mweststrate thank you. I have started writing types locally, but I had a problem with function arguments. For example: https://github.com/mobxjs/mobx/blob/master/src/api/observe.ts#L12-L17. I think this library will be useful, thank you.

@A-gambit
Copy link
Member

Already done in MobX3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants