Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array dehance (#1839) #1841

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Fix array dehance (#1839) #1841

merged 2 commits into from
Dec 11, 2018

Conversation

k-g-a
Copy link
Member

@k-g-a k-g-a commented Dec 11, 2018 •
edited
Loading

This PR fixes #1839.
There is also a PR for mobx@4.

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

No need for docs, typings, performance.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 93.625% when pulling fe2acb1 on k-g-a:fix-array-dehance into d55c50a on mobxjs:master.

@k-g-a k-g-a mentioned this pull request Dec 11, 2018
Closed
mweststrate
mweststrate approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!

@mweststrate mweststrate merged commit daf6ac0 into mobxjs:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweststrate mweststrate mweststrate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-g-a @coveralls @mweststrate @kga-kontur