Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObservableArrayAdministration.dehanceValues does not dehance last value #1839

Closed
k-g-a opened this issue Dec 11, 2018 · 2 comments
Closed

ObservableArrayAdministration.dehanceValues does not dehance last value #1839

k-g-a opened this issue Dec 11, 2018 · 2 comments

Comments

@k-g-a
Copy link
Member

k-g-a commented Dec 11, 2018

Originally found by @tarno0se at mobx-state-tree: issue #1105

When array.lenght === 1, dehanceValues() skips dehancing of last shift()/pop()'ed value.
This was referenced Dec 11, 2018
Merged
Merged
mweststrate added a commit that referenced this issue Dec 11, 2018
@mweststrate
Merge pull request #1841 from k-g-a/fix-array-dehance
daf6ac0 
Fix array dehance (#1839)
mweststrate added a commit that referenced this issue Dec 11, 2018
@mweststrate
Merge pull request #1840 from k-g-a/mobx4-fix-array-dehance
2547578 
Fix array dehance (#1839) for mobx4
@mweststrate
Copy link
Member

released in 4.8.0 / 5.8.0

@lock
Copy link

lock bot commented Jul 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @k-g-a