Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a configure env variable to mute minification warning (fix #1548) #1835

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

fi3ework
Copy link
Contributor

@fi3ework fi3ework commented Dec 7, 2018

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

To fix #1548, I add a simple env variable to force mute the warning in this PR. I wonder is it necessary to add it's usage to docs (as it may be rarely used) 😆

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.577% when pulling 337b6aa on fi3ework:fix-#1548 into d55c50a on mobxjs:master.

@mweststrate mweststrate merged commit 67e481c into mobxjs:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to suppress minified build warning
3 participants