Add option to suppress minified build warning

[jtheisen]

MobX doesn't like to be minified while not having the NODE_ENV set to production:

you are running a minified build, but 'process.env.NODE_ENV' was not set to 'production' in your bundler. This results in an unnecessarily large and slow bundle

I want both minification and keeping the React logging which won't happen with the suggested setting.

I don't think performance will be an issue for me.

Is there a way to get rid of that warning?

[mweststrate]

Afaik MobX follows the exact same pattern as React here. React will give the same error if I am not mistaken?

[jtheisen]

It sure used to. I think that's no longer the case.

[avioli]

@jtheisen Fork it and remove the offending check?

[mweststrate]

Or https://www.npmjs.com/package/patch-package, it's awesome!

[chase-moskal]

i'm also having this issue, but i can't figure out how else to express how productive i want my node env to be:

NODE_ENV=production browserify source/global.ts --debug -p [ tsify ] -t [ envify --NODE_ENV production ] -t uglifyify | uglifyjs -cm > dist/global.bundle.js

how can i satisfy the warning and fix my bundle?

edit: hey hey, i think i figured it out.. the following works:

NODE_ENV=production browserify source/global.ts -p [ tsify ] -g [ envify --NODE_ENV production ] -t uglifyify | uglifyjs -cm > dist/global.bundle.js

the difference that made it work, was simple changing the -t before [ envify to a -g instead

apparently that makes it globally affect the bundling or something

[avioli]

@chase-moskal That comment is for the browserify project. Not MobX.

[chase-moskal]

@avioli -- well sure, but i was reacting to this warning coming out of mobx:

"you are running a minified build, but 'process.env.NODE_ENV' was not set to 'production' in your bundler. This results in an unnecessarily large and slow bundle"

in my case, my answer was to change a browserify flag

hopefully some folks in my situation will find this tip

cheers

[mweststrate]

If somebody wants to add a configure option that supresses this warning, PR is welcome

[mweststrate]

See release notes of 4.8.0 / 5.8.0, it is now possible to override this using a global env variable (make sure to configure it in your build setup)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.