catch exception when parsing invalid pbf - fixes #817 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Safe to assume it builds successfully? Simply running 'make' in your work tree (if it's on the VM, as that has all the dependencies installed, and I have successfully compiled tippecanoe there,) would be enough to verify that. It looks right, so I believe it will build, but it's always good to check before handing it off to someone else. |
|
@nmr8acme I've run make and builds with no problems :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://acmeaom.slack.com/archives/G01N5K5MEM8/p1631835896026400
catch exception when decoding so that error message is printed