Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile-join: unknown pbf field type exception #817

Open
geeknik opened this issue Nov 19, 2019 · 2 comments
Open

tile-join: unknown pbf field type exception #817

geeknik opened this issue Nov 19, 2019 · 2 comments

Comments

@geeknik
Copy link
Contributor

geeknik commented Nov 19, 2019

While testing tile-join built from commit 065cc1d I encountered the following SIGABRT which is interfering with our normal testing. Was curious if this is a bug or something else? The only changes we've made to tippecanoe is to link /home/user/tippecanoe/protozero to /home/user/protozero/include/protozero to ensure the protozero code was up to date.

Command line:

$ ./tile-join -pk -o /dev/shm/tmp99.mbtiles -j '{ "hrusgeojson": [ "!=", "value", "Undefined" ] }' test0000 --force

Output:

terminate called after throwing an instance of 'protozero::unknown_pbf_wire_type_exception'
  what():  unknown pbf field type exception
Aborted

test0000.gz

@geeknik
Copy link
Contributor Author

geeknik commented Nov 19, 2019

I also have a couple of files that trigger the following errors if you're interested in receiving those.
protozero::end_of_buffer_exception

protozero::invalid_tag_exception

@e-n-f
Copy link
Contributor

e-n-f commented Nov 20, 2019

The test0000 mbtiles file appears to be corrupt in at least a couple of ways, so it does not surprise me that protozero also rejects PBFs within it as being invalid. Maybe I should add a try … catch block around the functions to give a better error message, though.

mmc1718 added a commit to mmc1718/tippecanoe that referenced this issue Sep 20, 2021
mmc1718 added a commit to mmc1718/tippecanoe that referenced this issue Sep 23, 2021
catch exception when parsing invalid pbf - fixes mapbox#817
mmc1718 added a commit to mmc1718/tippecanoe that referenced this issue Jun 21, 2023
ewsterrenburg pushed a commit to ewsterrenburg/tippecanoe that referenced this issue Dec 7, 2023
* catch exception when parsing invalid pbf - fixes mapbox#817

* updating exit error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants