Fix apply_bitmask logit for both CPU and triton versions when shape and stride doesn't match#390
Merged
Ubospica merged 4 commits intomlc-ai:mainfrom Aug 11, 2025
Merged
Conversation
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Ubospica
approved these changes
Aug 10, 2025
Collaborator
Ubospica
left a comment
There was a problem hiding this comment.
Thank you so much for your contribution!
strides are not considered previously. It's good that this PR fixes this issue.
In the future we will further use nanobind's ArrayList to simplify the logic of passing torch tensor to C++. See https://github.com/mlc-ai/xgrammar/blob/main/cpp/nanobind/nanobind.cc#L45. This can avoid the complex logic of passing shape, stride, and dtype, etc. separately to C++.
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Contributor
Author
Collaborator
|
@Jialin Thank you so much for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In vLLM, in order to address Issue #19493, PR #19565 served as a workaround to mitigate the issue by switching to use torch.compile version instead of triton version.
Root cause
With some investigation, we found that the error would happen when logits.stride()[0] != logits.shape[-1].
Changes
Tests
We've verified
Followup
We will follow up with a benchmark comparison to see if we should bring back triton-version or use the new cuda version on vLLM side.