Skip to content

Macos qt drag and drop fix#46

Merged
Swiftb0y merged 3 commits intomixxxdj:2.4from
daschuer:macos_qt_drag_and_drop
Jun 18, 2022
Merged

Macos qt drag and drop fix#46
Swiftb0y merged 3 commits intomixxxdj:2.4from
daschuer:macos_qt_drag_and_drop

Conversation

@daschuer
Copy link
Copy Markdown
Member

This aims to fix the drag and drop issue reported here: mixxxdj/mixxx#4717

This PR is on top of #45

@fwcd
Copy link
Copy Markdown
Member

fwcd commented Jun 11, 2022

I have filed https://bugs.launchpad.net/mixxx/+bug/1978384 for this, before I saw that you already looked into this. Thanks!

Since we won't get around patching the Qt build in the Intel version either now, we could probably upstream the M1 patches, even if Mixxx doesn't choose to officially provide binaries for ARM macOS, right?

@daschuer daschuer force-pushed the macos_qt_drag_and_drop branch from 4427046 to 4114e11 Compare June 11, 2022 22:57
@daschuer
Copy link
Copy Markdown
Member Author

Since we won't get around patching the Qt build in the Intel version either now, we could probably upstream the M1 patches, even if Mixxx doesn't choose to officially provide binaries for ARM macOS, right?

Yes, but lets go in steps.

@fwcd
Copy link
Copy Markdown
Member

fwcd commented Jun 15, 2022

I can confirm that the drag-n-drop patch works as expected (with the minor caveat that drag ghost images always seem to appear in the window's top left corner when dragging multiple tracks, this does not impact the actual functionality though and should not block the PR).

@daschuer
Copy link
Copy Markdown
Member Author

Nice news, thank you.

@daschuer daschuer requested a review from Swiftb0y June 16, 2022 05:42
@daschuer
Copy link
Copy Markdown
Member Author

@Swiftb0y: can you have a brief look here? We may merge this at one or the clean up PR first. This one applies upstream patches from QT 5.15

@daschuer daschuer force-pushed the macos_qt_drag_and_drop branch from 948edea to 8ff871a Compare June 17, 2022 06:03
@daschuer daschuer force-pushed the macos_qt_drag_and_drop branch from 8ff871a to c46931b Compare June 17, 2022 21:24
@daschuer
Copy link
Copy Markdown
Member Author

@Swiftb0y This is now rebased to 2.4, ready for review.

@Swiftb0y
Copy link
Copy Markdown
Member

Thank you. I don't quite understand what I'm looking at though. The two patch files, where did they originate from?

@daschuer
Copy link
Copy Markdown
Member Author

They are taken form here:
qt/qtbase@52e9c8b
and
qt/qtbase@8481a9f

@Swiftb0y
Copy link
Copy Markdown
Member

Ok thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants