Skip to content

MacOS Qt5 overlay clean up#45

Merged
Swiftb0y merged 4 commits intomixxxdj:2.4from
daschuer:qt5_overlay_clean_up
Jun 17, 2022
Merged

MacOS Qt5 overlay clean up#45
Swiftb0y merged 4 commits intomixxxdj:2.4from
daschuer:qt5_overlay_clean_up

Conversation

@daschuer
Copy link
Copy Markdown
Member

This is a set of patches that improves our Qt5.12 backport for MacOs

@daschuer daschuer force-pushed the qt5_overlay_clean_up branch from 05a6f4e to 3881cb4 Compare June 11, 2022 23:00
Comment thread overlay/osx/qt5-base/portfile.cmake Outdated
Comment on lines 176 to 181
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this? Is this a change from us or a patch from Qt5.15?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, this slips in from the M1 arm port.
I must have messed up the rebase.
I will rebase this again to remove that change.

@daschuer daschuer force-pushed the qt5_overlay_clean_up branch from 3881cb4 to 8da1a73 Compare June 17, 2022 05:58
@daschuer
Copy link
Copy Markdown
Member Author

Done.

Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Swiftb0y Swiftb0y merged commit 06db596 into mixxxdj:2.4 Jun 17, 2022
@daschuer daschuer deleted the qt5_overlay_clean_up branch January 5, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants