Skip to content

Pioneer-DDJ-SB2#822

Merged
rryan merged 16 commits intomixxxdj:1.12from
dg3nec:DDJ-SB2
Dec 22, 2015
Merged

Pioneer-DDJ-SB2#822
rryan merged 16 commits intomixxxdj:1.12from
dg3nec:DDJ-SB2

Conversation

@dg3nec
Copy link
Copy Markdown
Contributor

@dg3nec dg3nec commented Dec 21, 2015

Old:
Pioneer DDJ-SB2 controller #816
#816 (comment)

MiDi Controller Pioneer DDJ-SB2 for Mixxx since 1.12
Start first with version of controller "Pioneer DDJ-SB2"
Trim knob controls now "gain"
User option: preview jump forward (or not) and position. Defines to do
at release browser knob. by user.
FX little other use implemented and prevent a press knob when rotate
follows. Manual explains.
shift “key lock / tempo range” button the slider will fade slowly to 0.
Fadingspeed can be set in otions
Polished code with the named tools in controller wiki. Funktion gain
with filter eliminated.
Some no longer needed code deleted.
Additional a blank line added at the end
Inserted the link to the mixxx forum
Inserted a todo list in the script file for later work
- Link direkt to forum page 1
- Link direkt into wiki
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Dec 21, 2015

Looks good to me! 👍 Thank you! I'm really glad Mixxx 2.0 will support this cheaper but recent and capable controller. I'm sure many DJs will be grateful for this. :)

@dg3nec
Copy link
Copy Markdown
Contributor Author

dg3nec commented Dec 21, 2015

Uffff....... first one.
Now i transfer midi_for_light PR.

@rryan
Copy link
Copy Markdown
Member

rryan commented Dec 21, 2015

@dg3nec looks like you need to merge first -- could you run git merge origin/1.12?

@rryan rryan mentioned this pull request Dec 21, 2015
@dg3nec
Copy link
Copy Markdown
Contributor Author

dg3nec commented Dec 22, 2015

@rryan: Sorry, not realy know exactly whats to do.

@dg3nec dg3nec closed this Dec 22, 2015
@dg3nec dg3nec reopened this Dec 22, 2015
@rryan
Copy link
Copy Markdown
Member

rryan commented Dec 22, 2015

No problem @dg3nec I'll take it from here.

@rryan rryan merged commit f6474e8 into mixxxdj:1.12 Dec 22, 2015
rryan added a commit that referenced this pull request Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants