Pioneer DDJ-SB2 controller by dg3nec · Pull Request #816 · mixxxdj/mixxx

dg3nec · 2015-12-19T14:22:18Z

New 4 deck controller pioneer DDJ-SB2 for mixxx 1.12 and up. Tested with r5719.

MiDi Controller Pioneer DDJ-SB2 for Mixxx since 1.12

Start first with version of controller "Pioneer DDJ-SB2"

Trim knob controls now "gain"

User option: preview jump forward (or not) and position. Defines to do at release browser knob. by user.

FX little other use implemented and prevent a press knob when rotate follows. Manual explains.

shift “key lock / tempo range” button the slider will fade slowly to 0. Fadingspeed can be set in otions

Polished code with the named tools in controller wiki. Funktion gain with filter eliminated. Some no longer needed code deleted.

dg3nec · 2015-12-19T14:34:28Z

Big sorry, there is one file too much.
Please delete: sync.ffs_db !!!!

Pegasus-RPG · 2015-12-19T15:55:06Z

We can't delete files in your branch, but you can just do "git rm [filename]" then commit and push to delete it from the repo.

Be-ing · 2015-12-19T17:43:00Z

Thanks for submitting this. I'll take a look through it today.

Be-ing · 2015-12-19T19:19:24Z

I've been editing the wiki page to clarify the language.

Do you know if the DDJ-SB2 works with Linux? I suspect it is a USB class compliant MIDI and audio device, but it would be good to confirm. Considering Pioneer's website says no driver is needed on Mac OS X, it is probably class compliant.
If you don't have Linux installed on your computer, you can put Crossfade GNU/Linux (http://nongnu.org/crossfade/ ) on a USB drive or CD to test. Crossfade 0.90 is quite outdated at this point and still has Mixxx 1.11. You don't need to test whether the mapping works, but just make sure that the controller shows up in the preferences and you can get sound out of the sound card. If you don't have much time to check this out before Mixxx 2.0 is released, don't worry about it.

Be-ing · 2015-12-19T20:26:18Z

Be-ing · 2015-12-19T23:41:46Z

Update the mixxxVersion in the XML file to 2.0.

Be-ing · 2015-12-19T23:46:05Z

I read through the wiki page and clarified the language. Everything seems to be mapped in a nice, intuitive way. Other than the few questions/comments I left above, looks good. :)

Be-ing · 2015-12-19T23:58:21Z

Btw, is the microphone input sent to the computer or is it mixed directly with the output of the sound card?

dg3nec · 2015-12-20T14:26:15Z

Microfon will be used only controller internal. No input in Mixxx.
But it works well. I have tested one time with a old dynamic mic and the sound was good.

Wau, you give a little homework :-). I make this step by step.

Additional a blank line added at the end

dg3nec · 2015-12-20T15:43:40Z

OK, thanks for your hints what's to do. All done ( i hope hi hi). Tested on w64 with r5790. Next step?

Be-ing · 2015-12-20T18:48:19Z

Just put a comment somewhere in the script about PioneerDDJSB2.deckSwitchTable[group] with "TODO" so it isn't forgotten about. Other than that, LGTM 👍

rryan · 2015-12-20T19:40:53Z

Thanks @dg3nec! Could you please add wiki / forum links to your XML file?

Inserted the link to the mixxx forum

dg3nec · 2015-12-20T20:55:32Z

Link to the forum is done

rryan · 2015-12-20T20:59:14Z

Link to the forum is done

Sorry for not being more specific, I meant the thread discussing your preset:
http://www.mixxx.org/forums/viewtopic.php?f=7&t=7509

And since there's an &, in the XML it needs to be: http://www.mixxx.org/forums/viewtopic.php?f=7&t=7509

Also a wiki link to http://mixxx.org/wiki/doku.php/pioneer_ddj-sb2 would be nice. This way Mixxx will show direct links to teh forum thread and wiki page in the app.

Inserted a todo list in the script file for later work

- Link direkt to forum page 1 - Link direkt into wiki

dg3nec · 2015-12-20T21:25:22Z

Forum, wiki and to do is done

rryan · 2015-12-20T21:47:45Z

👍 thank you

Be-ing · 2015-12-20T21:58:19Z

I just realized this pull request is targeted at the master branch rather than 1.12. Close this PR and open a new one targeted at the 1.12 branch (renaming the branch to 2.0 would be too much of a hassle right now). You don't have to change anything in your git repository; just open a new PR on the GitHub website.

Be-ing · 2015-12-21T12:38:46Z

Annoyingly, GitHub doesn't have a way to change the branch a pull request targets. You have to make a new pull request for the 1.12 branch.

rryan · 2015-12-21T21:26:20Z

Closing in favor of #822. Thanks @dg3nec !

dg3nec added 7 commits November 28, 2015 17:39

DDJ-SB2

3aed40e

MiDi Controller Pioneer DDJ-SB2 for Mixxx since 1.12

Startpoint

09bf779

Start first with version of controller "Pioneer DDJ-SB2"

Trim Knob implemented

edfbf49

Trim knob controls now "gain"

Useroption Preview Release config

3a467c2

User option: preview jump forward (or not) and position. Defines to do at release browser knob. by user.

FX buttons and knobs change

47f9b3c

FX little other use implemented and prevent a press knob when rotate follows. Manual explains.

soft fading tempo to 0

8e8de33

shift “key lock / tempo range” button the slider will fade slowly to 0. Fadingspeed can be set in otions

Polish code

0055c29

Polished code with the named tools in controller wiki. Funktion gain with filter eliminated. Some no longer needed code deleted.

dg3nec changed the title ~~Ddj sb2 controller~~ Pioneer Ddj sb2 controller Dec 19, 2015

Be-ing reviewed Dec 19, 2015
View reviewed changes

Comment thread res/controllers/Pioneer-DDJ-SB2-scripts.js Outdated

Copy link
Copy Markdown

Contributor

Be-ing Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixxx 2.0

dg3nec added 6 commits December 20, 2015 15:50

Was a mistake from side, file deleted

2697262

Update Pioneer-DDJ-SB2-scripts.js

3c31ef5

blinkingsync ste default to false

aca90ea

change a 0 to false

2d936d6

the two + eleminated and also () eleminated

2b96457

Additional a blank line added at the end

Version mixx changed to 2.0+

39e0631

dg3nec changed the title ~~Pioneer Ddj sb2 controller~~ Pioneer DDJ-SB2 controller Dec 20, 2015

Forum link inserted

41f1dbd

Inserted the link to the mixxx forum

dg3nec added 2 commits December 20, 2015 22:06

TODO inserted in JS at top

197544a

Inserted a todo list in the script file for later work

Forum and wiki link

f6474e8

- Link direkt to forum page 1 - Link direkt into wiki

dg3nec closed this Dec 21, 2015

dg3nec reopened this Dec 21, 2015

dg3nec closed this Dec 21, 2015

dg3nec reopened this Dec 21, 2015

dg3nec closed this Dec 21, 2015

dg3nec reopened this Dec 21, 2015

This was referenced Dec 21, 2015

Pioneer-DDJ-SB2_1.12 #821

Closed

Pioneer-DDJ-SB2 #822

Merged

rryan closed this Dec 21, 2015

Be-ing mentioned this pull request May 5, 2016

fixed the controller mappings for ION-discover DJ #936

Merged

Uh oh!

Conversation

dg3nec commented Dec 19, 2015

Uh oh!

dg3nec commented Dec 19, 2015

Uh oh!

Pegasus-RPG commented Dec 19, 2015

Uh oh!

Be-ing commented Dec 19, 2015

Uh oh!

Be-ing commented Dec 19, 2015

Uh oh!

Be-ing Dec 19, 2015

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Dec 19, 2015

Uh oh!

Be-ing commented Dec 19, 2015

Uh oh!

Be-ing commented Dec 19, 2015

Uh oh!

dg3nec commented Dec 20, 2015

Uh oh!

dg3nec commented Dec 20, 2015

Uh oh!

Be-ing commented Dec 20, 2015

Uh oh!

rryan commented Dec 20, 2015

Uh oh!

dg3nec commented Dec 20, 2015

Uh oh!

rryan commented Dec 20, 2015

Uh oh!

dg3nec commented Dec 20, 2015

Uh oh!

rryan commented Dec 20, 2015

Uh oh!

Be-ing commented Dec 20, 2015

Uh oh!

Be-ing commented Dec 21, 2015

Uh oh!

rryan commented Dec 21, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants